[swift-dev] SR-122 / CollectionsMoveIndices.swift Prototype

[Austin Zheng]

> On Feb 22, 2016, at 7:54 AM, Dave Abrahams <dabrahams at apple.com> wrote:
> 
> 
> on Sun Feb 21 2016, Austin Zheng <austinzheng-AT-gmail.com <http://austinzheng-at-gmail.com/>> wrote:
> 
>> I copy-pasted the prototype code into Collections.swift (commenting
>> out the old code), 
> 
> Request: don't comment out old code; it just makes a mess and makes
> changesets harder to analyze.  The old code is still available; that's
> what Git is for.
> 

Of course, you mentioned this before. I'll make sure it goes away.

>> renamed the types that conflicted with the naming guidelines, and am
>> going through the errors one at a time to get the project into a
>> buildable state. This might take a few more days. Let me know if there
>> are any objections to this approach.
> 
> None whatsoever.  If you can push your WIP to some publicly-visible
> repository, maybe you could find a way to share the effort of fixing
> errors with Shawn...?

I'll push what I have to my local repo, but it's a very brute-force approach. Like Shawn, I don't know if this is the *best* way; if necessary we can go with his more methodical approach.

Austin

> 
>> 
>> Austin
>> 
>>> On Feb 21, 2016, at 6:21 PM, Dave Abrahams <dabrahams at apple.com> wrote:
>>> 
>>> Until we open commit access, they still need one or more repos to
>>> push to and create PRs from. Seems better for them to have an org
>>> repo for that so other collaborators have a centralized place to go
>>> for the latest non-integrated work.
>>> 
>>> Sent from my moss-covered three-handled family gradunza
>>> 
>>>> On Feb 21, 2016, at 5:34 PM, Austin Zheng <austinzheng at gmail.com> wrote:
>>>> 
>>>> Hi Dmitri (et al),
>>>> 
>>>> I have no personal objection to pull requests. If PRs directly to
>>>> the Swift project are the best way to do things, let's keep it that
>>>> way.
>>>> 
>>>> Austin
>>>> 
>>>>> On Feb 21, 2016, at 5:24 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>>>>> 
>>>>> On Sun, Feb 21, 2016 at 12:13 PM, Austin Zheng <austinzheng at gmail.com> wrote:
>>>>>> Agreed. I created a GitHub organization
>>>>>> ('swift-stdlib-opensource-collaborators'), and will try to invite the
>>>>>> non-Apple ('outsider') folks to join. Once that's happened, maybe Shawn can
>>>>>> move his fork under the organization, or one of us can fork the repo again.
>>>>> 
>>>>> Hi Austin, Shawn,
>>>>> 
>>>>> We're still working out the general policy for commit access for
>>>>> non-Apple contributors.
>>>>> 
>>>>> I'm trying to understand the situation better -- could you explain why
>>>>> pull requests present too much overhead for this project?  Many Apple
>>>>> engineers who have commit access find that the pull request approach
>>>>> works better for their day-to-day work.
>>>>> 
>>>>> My concern is that doing this work in a parallel organization hides
>>>>> this project from other contributors who might be interested.  Also,
>>>>> you would only get CI coverage in the primary Swift organization.  In
>>>>> general, creating a parallel organization sends an ambiguous message
>>>>> to other people working on the project.
>>>>> 
>>>>> Furthermore, even Shawn started his work on this project with a pull
>>>>> request against his fork (https://github.com/shawnce/swift/pull/1).
>>>>> 
>>>>> Could we start with pull requests against the swift-3-indexing-model
>>>>> branch in the primary repository, and possibly move to direct commits
>>>>> later?
>>>>> 
>>>>> Dmitri
>>>>> 
>>>>> -- 
>>>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>>>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>>>> 
> 
> -- 
> -Dave

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20160222/5127fe12/attachment.html>