[swift-dev] [Swift 2.2] IRGen: Don't try to bind witness tables for archetype protocol requirements that don't need them.

Joe Pamer jpamer at apple.com
Tue Feb 9 17:02:02 CST 2016


Your ringing endorsement, coupled with the fact that the CI tests are passing, means this change is approved for 2.2. Joe, please feel free to cherry-pick the change to swift-2.2-branch.

Thanks!
- Joe

> On Feb 9, 2016, at 2:43 PM, Slava Pestov <spestov at apple.com> wrote:
> 
> I don't claim to have any kind of deep understanding of IRGen, but this change makes sense to me.
> 
> Slava
> 
>> On Feb 9, 2016, at 1:12 PM, Joe Pamer <jpamer at apple.com> wrote:
>> 
>> Thanks, Joe! The PR looks good to me, but would someone more familiar with IRGen mind taking a quick look? (Slava?)
>> 
>> - Joe
>> 
>>> On Feb 9, 2016, at 1:08 PM, Joe Groff <jgroff at apple.com> wrote:
>>> 
>>> Hey Joe, I'm testing a fix for a crash regression reported on Swift 2.2 as rdar://problem/24568361. I'd like to get this cherry-picked into the 2.2 branch.
>>> 
>>> https://github.com/apple/swift/pull/1245
>>> 
>>> -Joe
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20160209/88c0c709/attachment.html>


More information about the swift-dev mailing list