[swift-dev] SourceKit limits on Swift refactoring

[Xi Ge]

Hi Xin,
It seems that the cursor info crash is not your blocker : (  Could you point me to the refactoring plugin source? I can investigate better if I know which SourceKit request is used by it.
Thanks
Xi 
> On Jan 12, 2016, at 5:58 PM, 肇鑫 <owenzx at gmail.com> wrote:
> 
> Hi Xi Ge,
> 
> I just tried the swift-2.2-SNAPSHOT-2016-01-11-a-osx.pkg with Xcode 7.2 (7C68). The results is still the same, should I wait for another snapshot as this one is not included your patch?
> 
> My steps:
> 
> 1 download swift-2.2-SNAPSHOT-2016-01-11-a-osx.pkg, install it
> 2 command line, run `xcrun launch-with-toolchain /Library/Developer/Toolchains/swift-latest.xctoolchain`
> 3 rebuild the plugin, quit xcode
> 4 open xcode with the command line
> 5 open the project which contains the test code 
> 
> struct Person {
>     var name:String
>     
>     init(aName:String) {
>         self.name <http://self.name/> = aName
>     }
> }
> 
> func testOnly() {
>     let john = Person(aName: "John")
>     
>     print(john)
> }
> 
> 6 clean and rebuild the project
> 
> zhaoxin
> 
> On Tue, Jan 12, 2016 at 3:35 AM, Xi Ge <xi_ge at apple.com <mailto:xi_ge at apple.com>> wrote:
> HI Xin,
> I have fixed this crash in open source Swift. Please let me know if the progress unlocks your refactoring support.
> cheers
> Xi
> 
> 
> 
>> On Jan 9, 2016, at 6:45 PM, 肇鑫 <owenzx at gmail.com <mailto:owenzx at gmail.com>> wrote:
>> 
>> Thanks. Refactor really makes working much easier. Looking forward to the progress.
>> 
>> zhaoxin
>> 
>> On Sun, Jan 10, 2016 at 5:37 AM, Xi Ge <xi_ge at apple.com <mailto:xi_ge at apple.com>> wrote:
>> Hi Xin,
>> I tried the case you gave here and got a SourceKit crash in the line of "self.name <http://self.name/> = aName” when querying cursor info. I will get into this by Monday. 
>> Thanks for letting us know!
>> Xi
>> 
>>> On Jan 9, 2016, at 1:15 PM, 肇鑫 via swift-dev <swift-dev at swift.org <mailto:swift-dev at swift.org>> wrote:
>>> 
>>> SourceKit
>> 
>> 
>> 
>> 
>> -- 
>> 
>> Owen Zhao
> 
> 
> 
> 
> -- 
> 
> Owen Zhao

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-dev/attachments/20160112/98bcd9c0/attachment.html>