[swift-dev] swift without markup/cmark

[Rafkind, Jon]

I will be distributing swift as part of a commercial application, and have to disclose all third party libraries due to the open source requirements. The fewer components I have to deal with the better.

Also, I routinely have to mess with the swift build system to get it to find the cmark headers. In the most recent build I did I had to copy the cmark headers to lib/Markup, because Markup.cpp directly tries to #include "cmark.h", but cmake does not have a variable to specify the location of the cmark include directory, it only has one for the lib directory.

On 01/08/2016 12:51 PM, Dmitri Gribenko wrote:

On Fri, Jan 8, 2016 at 10:36 PM, Rafkind, Jon via swift-dev
<swift-dev at swift.org><mailto:swift-dev at swift.org> wrote:


I would like to build swift without support for its markup feature, and in turn leave out the cmark dependency. It looks like markup is used in a few places, such as AST/DocComment.cpp, a few files in IDE/, and PrintAsObjC/PrintAsObjC.cpp.

My initial guess to accomplish this is a new cmake variable, WANT_MARKUP, could be added that provides the define -DWANT_MARKUP, and the various code paths that use the Markup stuff can check for it using an #ifdef.

If I attempted such a thing would it have a chance to be accepted as a patch?



In general we try to limit the number of build configurations we
support.  What is the motivation for this one?  cmark is a small
library, as compared to, say, LLVM.

Dmitri



--