<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 18, 2017, at 9:29 AM, Benoit Pereira da silva <<a href="mailto:bpds@me.com" class="">bpds@me.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Thanks Philippe,<div class=""><br class=""></div><div class=""><br class=""><div class=""><blockquote type="cite" class=""><span class="" style="float: none; display: inline !important;">Good find, </span><div class="">You can make a pull request and we can get our continuous integration servers to start building that and testing your change – that is probably the easiest way to get validation on your tests and changes.</div><div class="">There are a few issues however with your test that might be worth considering. Comments inline…</div></blockquote>… </div><div class=""><blockquote type="cite" class=""><div class=""><div class=""><div class="">Building a CLI tool will use the objective-c Foundation in the system so that wont use your freshly built swift-corelibs-foundation. So that means we have a bug in the objc side if this is actually happening on Darwin (which is a completely different issue…) That should be a radar against Foundation and I definitely think that may very well be a bug… </div></div></div></blockquote></div><div class=""><div class=""><div class=""><div class=""><br class=""></div></div></div></div><div class=""><div class="">I have been filling a radar <a href="https://bugreport.apple.com/web/?problemID=36107307" class="">https://bugreport.apple.com/web/?problemID=36107307</a></div></div></div></div></div></blockquote><div><br class=""></div><div>Thanks for taking the time to file that! I will make sure that gets to the right owner.</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><div class=""><div class="">I do think you are right it's a bug in the Objc Foundation… and trying to solve it in "swift-corelibs-foundation" was a mistake :) </div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div class=""><blockquote type="cite" class=""><div class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div class=""><blockquote type="cite" class=""><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div class=""><div class=""><div class="" style="margin: 0px; font-stretch: normal; font-size: 9.5px; line-height: normal; font-family: Menlo; color: rgb(189, 178, 160); background-color: rgb(0, 58, 93);"><span class="" style="font-size: 12px;"> <span class="" style="color: rgb(118, 194, 255);">setlocale</span>(<span class="" style="color: rgb(0, 177, 255);">LC_ALL</span>,<span class="" style="color: rgb(171, 69, 71);">"fr_FR”</span>)</span></div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">This change will set the locale globally for the rest of the process, you probably want to make sure to reset the locale back to it’s original state.</div></div></div></blockquote><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Setting the locale globally was just a temporary test.</div><div class=""><br class=""></div><div class="">But i do think that it triggers a serious question: Should all your tests be ran on all the available locales? </div><div class="">You will certainly find a smarter solution …</div></div></div></div></div></div></blockquote><div><br class=""></div><div>I think it is sensible to iterate through a key list of known locales that have certain characteristics, such as using the , as a decimal separator or « for quote begin etc (not to pick on French but it is the one I know better than other punctuation differentials from English).</div><div><br class=""></div><div>There are probably key areas that are worth doing this to and others that probably do not matter so much. e.g. you don’t really need to test locale variations with NotificationCenter for example whereas NumberFormatter or JSONSerialization may be places that we want to test a few locales by subclassing the unit tests and in setup change the locale and teardown reset it.</div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class=""><div class=""><div class=""><div class=""><br class=""></div><div class="">Benoit</div><div class=""><br class=""></div><div class=""><div class=""><br class=""></div><div class=""><br class=""></div></div></div></div></div></div></div></blockquote></div><br class=""></body></html>