<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div><blockquote type="cite" class=""><div class="">On Oct 12, 2017, at 7:48 AM, Rogiel Sulzbach <<a href="mailto:rogiel@rogiel.com" class="">rogiel@rogiel.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<title class=""></title>
<div class="">
<div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;" class=""><div style="margin: 0px; padding: 0px; color: rgb(51, 51, 51); font-family: Arial, sans-serif;" class="">I am trying to get libdispatch working on FreeBSD but I am hitting a wall: I cannot get my head around how the runloop implementation dispatches a event to the <b class="">kqueue</b> once a new job is submitted. So far I was able to get the library to fully compile but most tests are timing out due to a issue getting the kqueue event handler to awake when the <b class="">poke</b> method is called.</div><p style="margin: 10px 0px 0px; padding: 0px; color: rgb(51, 51, 51); font-family: Arial, sans-serif;" class="">Looking at the Linux implementation (<a href="https://github.com/apple/swift-corelibs-libdispatch/blob/master/src/queue.c#L6119)" rel="nofollow" style="color: rgb(59, 115, 175); text-decoration: none; cursor: pointer;" class="external-link">https://github.com/apple/swift-corelibs-libdispatch/blob/master/src/queue.c#L6119)</a> it appears to be creating a new <b class="">eventfd</b> descriptor and calls <b class="">eventfd_write</b> on the <b class="">poke</b> method. A <b class="">eventfd_read</b> call is only made in the <b class="">event_epoll.c</b> implementation file BUT I am unable to find where the specific fd (created in <b class="">queue.c</b>) is forwarded to the epool handler. In other words, <ins class="">how is the event queue implementation informed of that file descriptor?</ins></p><p style="margin: 10px 0px 0px; padding: 0px; color: rgb(51, 51, 51); font-family: Arial, sans-serif;" class="">On the Darwin side of things, it appears to use a mix of <b class="">kqueue</b> (on the event handling side) and mach ports (on the signaling side), but i still cannot understand how the <b class="">event_kevent.c</b> implementation becomes aware of that port allocated on <b class="">queue.c</b>.</p><p style="margin: 10px 0px 0px; padding: 0px; color: rgb(51, 51, 51); font-family: Arial, sans-serif;" class="">In order do get dispatch working on FreeBSD I need to be able to understand the flow that happens between <b class="">_dispatch_runloop_queue_class_poke</b> and a event getting fired in the kqueue implementation (which I believe should be happening in <b class="">_dispatch_kq_poll</b>).</p><p style="margin: 10px 0px 0px; padding: 0px; color: rgb(51, 51, 51); font-family: Arial, sans-serif;" class=""><br class=""></p><p style="margin: 10px 0px 0px; padding: 0px;" class=""><font color="#333333" face="Arial, sans-serif" class="">Pierre Habouzit replied to me on the bug tracker:</font></p>
<blockquote style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;" class=""><p style="margin: 10px 0px 0px; padding: 0px;" class=""><span style="color: rgb(51, 51, 51); font-family: Arial, sans-serif; background-color: rgb(255, 255, 255);" class="">The equivalent of the eventfd on kevent systems is to use an EVFILT_USER. It is very likely that the current implementation using kevent is badly broken on FreeBSD it has never run for a very long time. I have no access to FreeBSD at this time to help though but I can help with questions on the list.</span></p>
</blockquote>
<font color="#333333" face="Arial, sans-serif" class="">Indeed, the entire library needed changes in 39 files to get compiling, let alone working! But I am getting there!</font>
</div></div></div></blockquote><div><br class=""></div><div>39 seems a bit excessive so I'd encourage you when you submit this awesome porting effort to try to check in individual "porting fixes" in separate branches.</div><div><br class=""></div><div>You should also try to get it working at the C level before you try to integrate with Swift, runloop queues are not required to get the basic library working</div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;" class=""><div class=""><font color="#333333" face="Arial, sans-serif" class=""><br class=""></font></div>
<div class=""><font color="#333333" face="Arial, sans-serif" class="">If i am understanding it correctly, I must send a EVFILT_USER and upon receiving that event I get the corresponding unote and call dux_merge_evt. Right?</font></div>
</div></div></div></blockquote><br class=""></div><div>Hmm actually when answering on Jira I had missed that you were talking about runllops. However, the equivalent of eventfd on kevent will be EVFILT_USER.</div><div><br class=""></div><div>You will need to first work on the implementation of CFRunloop itself to understand how it "blocks". It will likely park in kevent() with a kqueue fd.</div><div><br class=""></div><div>The CFRunloop in question will prepare an EVFILT USER that represents "availability" of dispatch items to drain in the runloop queue. the difficulty is that unlike epoll of portsets on the Mac, the runloop queue has to know your kqueue fd. So you need to devise a way to pass it down.</div><div><br class=""></div><div>Once you have done that _dispatch_runloop_queue_class_poke() on FreeBSD will issue a NOTE_TRIGGER of the EVFILT_USER which will break the CFRunloo parked in kqueue() out, and this will recognize the EVFILT_USER as being the hint that you need to drain it.</div><div><br class=""></div><div>I would suggest that on FreeBSD you add a _dispatch_runloop_queue_set_kqueue() which you will store where the fd/mach port is stored on other platforms.</div><div><br class=""></div><div>-Pierre</div><br class=""></body></html>