<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jun 21, 2017, at 6:30 AM, Alex Blewitt via swift-corelibs-dev <<a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">We had a test failure on swift-corelibs-foundation recently on master, which was related to this pull request being merged by me:<div class=""><br class=""></div><div class=""><a href="https://github.com/apple/swift-corelibs-foundation/pull/1043" class="">https://github.com/apple/swift-corelibs-foundation/pull/1043</a></div><div class=""><br class=""></div><div class="">The automated tests passed, but after being committed to master, they then failed. I subsequently rolled them back with this pull request:</div><div class=""><br class=""></div><div class=""><a href="https://github.com/apple/swift-corelibs-foundation/pull/1056" class="">https://github.com/apple/swift-corelibs-foundation/pull/1056</a></div><div class=""><br class=""></div><div class="">A few interim builds have failed; if you see messages like failing to compare metric and imperial measurements, that could have been caused by this. Rebasing and redoing such test failures should fix the issues.</div><div class=""><br class=""></div><div class="">It's a bit concerning that the test case failed after merge but passed in the pull request test. Is this expected?</div></div></div></blockquote><div><br class=""></div>I’m not 100% sure that our test cases are being run against a clean build, which has been the root of some confusion like this in the past.</div><div><br class=""></div><div>- Tony</div><div><br class=""><blockquote type="cite" class=""><div class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><br class=""></div><div class="">Alex</div><div class=""><div class="timeline-comment-wrapper js-comment-container" style="box-sizing: border-box; position: relative; padding-left: 60px; margin-top: 15px; margin-bottom: 15px; border-top-width: 2px; border-top-style: solid; border-top-color: rgb(255, 255, 255); border-bottom-width: 2px; border-bottom-style: solid; border-bottom-color: rgb(255, 255, 255); color: rgb(36, 41, 46); font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 14.000000953674316px;"><div id="issuecomment-310053757" class=" timeline-comment previewable-edit js-task-list-container js-reorderable-task-lists reorderable-task-lists js-comment comment current-user" data-body-version="7f468d3e624d581abfa770893dc52027" style="box-sizing: border-box; position: relative; background-color: rgb(255, 255, 255); border: 1px solid rgb(192, 211, 235); border-top-left-radius: 3px; border-top-right-radius: 3px; border-bottom-right-radius: 3px; border-bottom-left-radius: 3px;"><div class="edit-comment-hide" style="box-sizing: border-box;"><table class="d-block" style="box-sizing: border-box; border-spacing: 0px; border-collapse: collapse; display: block !important;"><tbody class="d-block" style="box-sizing: border-box; display: block !important;"><tr class="d-block" style="box-sizing: border-box; display: block !important;"><td class="markdown-body comment-body d-block js-comment-body" style="box-sizing: border-box; padding: 15px; font-size: 14px; line-height: 1.5; word-wrap: break-word; width: 698.2608642578125px; overflow: visible; display: block !important;"><pre style="box-sizing: border-box; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, Courier, monospace; font-size: 11.899999618530273px; margin-top: 0px; line-height: 1.45; word-wrap: normal; padding: 16px; overflow: auto; background-color: rgb(246, 248, 250); border-top-left-radius: 3px; border-top-right-radius: 3px; border-bottom-right-radius: 3px; border-bottom-left-radius: 3px; margin-bottom: 0px !important;" class=""><code style="box-sizing: border-box; font-family: SFMono-Regular, Consolas, 'Liberation Mono', Menlo, Courier, monospace; padding: 0px; margin: 0px; background-color: transparent; border-top-left-radius: 3px; border-top-right-radius: 3px; border-bottom-right-radius: 3px; border-bottom-left-radius: 3px; word-break: normal; border: 0px; display: inline; overflow: visible; line-height: inherit; word-wrap: normal;" class="">Test Case 'TestNSLengthFormatter.test_stringFromMetersMetric' started at 2017-06-21 10:16:31.688
TestFoundation/TestNSLengthFormatter.swift:71: error: TestNSLengthFormatter.test_stringFromMetersMetric : XCTAssertEqual failed: ("-6.214 mi") is not equal to ("-10 km") -
TestFoundation/TestNSLengthFormatter.swift:72: error: TestNSLengthFormatter.test_stringFromMetersMetric : XCTAssertEqual failed: ("-0.001 mi") is not equal to ("-0.001 km") -
TestFoundation/TestNSLengthFormatter.swift:73: error: TestNSLengthFormatter.test_stringFromMetersMetric : XCTAssertEqual failed: ("0 in") is not equal to ("0.01 mm") -
</code></pre></td></tr></tbody></table><div class=" comment-reactions js-reactions-container js-socket-channel js-updatable-content" data-channel="reaction:issue-comment:310053757" data-url="/_render_node/MDEyOklzc3VlQ29tbWVudDMxMDA1Mzc1Nw==/comments/reactions" style="box-sizing: border-box;"></div></div><form accept-charset="UTF-8" action="https://github.com/apple/swift-corelibs-foundation/issue_comments/310053757" class="js-comment-update" data-remote="" data-type="json" data-upload-policy-authenticity-token="Vwn2MUXdW2I5uiSlW4KXf+HBWS1HQn/4Qa/2luUzhhAsYTW19uVh7bEdmpnNNBvs1Jni/vjkaxt9/INc3Y/QRA==" data-upload-policy-url="/upload/policies/assets" method="post" style="box-sizing: border-box;"><div style="box-sizing: border-box; margin: 0px; padding: 0px; display: inline;" class=""></div></form></div></div><div class="timeline-comment-wrapper js-comment-container" style="box-sizing: border-box; position: relative; padding-left: 60px; margin-top: 15px; margin-bottom: 15px; border-top-width: 2px; border-top-style: solid; border-top-color: rgb(255, 255, 255); border-bottom-width: 2px; border-bottom-style: solid; border-bottom-color: rgb(255, 255, 255); color: rgb(36, 41, 46); font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 14.000000953674316px;"></div></div></div>_______________________________________________<br class="">swift-corelibs-dev mailing list<br class=""><a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-corelibs-dev<br class=""></div></blockquote></div><br class=""></body></html>