<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">There's a test which attempts to download an XML DTD from an external file, which fails when there's an intermittent network connection:<div class=""><br class=""></div><div class=""> Test Case 'TestNSArray.test_writeToFile' started at 09:15:53.214<br class=""> I/O warning : failed to load external entity "<a href="http://www.apple.com/DTDs/PropertyList-1.0.dtd" class="">http://www.apple.com/DTDs/PropertyList-1.0.dtd</a>"<br class=""> .../swift-corelibs-foundation/TestFoundation/TestNSArray.swift:492: error: TestNSArray.test_writeToFile : failed - XMLDocument failes to read / validate contenets<br class=""><br class=""></div><div class="">It's probably not a good idea to have remote DTD parsing enabled, especially for testing a write to file method. Plus, there's a spelling error or two :)</div><div class=""><br class=""></div><div class="">This happens because the XML document has 'validate' called on it:</div><div class=""><br class=""></div><div class=""> let plistDoc = try XMLDocument(contentsOf: URL(fileURLWithPath: testFilePath!, isDirectory: false), options: [])<br class=""> try plistDoc.validate()<br class=""><br class=""></div><div class=""><a href="https://github.com/apple/swift-corelibs-foundation/blob/e05884bd835f6ee22e7c0b0484326d63c31d554a/TestFoundation/TestNSArray.swift#L485-L486" class="">https://github.com/apple/swift-corelibs-foundation/blob/e05884bd835f6ee22e7c0b0484326d63c31d554a/TestFoundation/TestNSArray.swift#L485-L486</a></div><div class=""><br class=""></div><div class="">I don't think the validate call is adding anything here, because if it's invalid then the subsequent assert will fail, and we're just testing whether or not we can read the contents from file.</div><div class=""><br class=""></div><div class="">Should we remove the try/validate statement here?</div><div class=""><br class=""></div><div class="">Alex</div></body></html>