<html><body><p>We think that the libdispatch incremental rebuilds didn't know that if swiftc changed it needed to invalidate the compilation of the swift dispatch overlay files (missing dependency in the make rule). A localized change that could be enough to fix the problem is libdispatch PR #178. If that isn't enough, we might have to do a more ambitious restructuring of the libdispatch build.<br><br>--dave<br><br><img width="16" height="16" src="cid:1__=0ABB0AA9DFCDBA5D8f9e8a93df938690918c0AB@" border="0" alt="Inactive hide details for Jordan Rose ---09/26/2016 01:07:24 PM---Oh, I didn’t realize we had a separate copy of the overlay c"><font color="#424282">Jordan Rose ---09/26/2016 01:07:24 PM---Oh, I didn’t realize we had a separate copy of the overlay code (almost certainly the right thing to</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Jordan Rose <jordan_rose@apple.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">David P Grove/Watson/IBM@IBMUS</font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">"Daniel A. Steffen" <dsteffen@apple.com>, swift-dev <swift-dev@swift.org>, swift-corelibs-dev <swift-corelibs-dev@swift.org></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">09/26/2016 01:07 PM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [swift-dev] Swift CI PR builder dispatch linux failure</font><br><font size="2" color="#5F5F5F">Sent by: </font><font size="2">jordan_rose@apple.com</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><font size="4">Oh, I didn’t realize we had a separate copy of the overlay code (almost certainly the right thing to do at this point). But in that case, why are we seeing any of these errors?</font><br><br><font size="4">Jordan</font><br>
<ul><ul><font size="4">On Sep 25, 2016, at 11:38, David P Grove <</font><a href="mailto:groved@us.ibm.com"><u><font size="4" color="#0000FF">groved@us.ibm.com</font></u></a><font size="4">> wrote:</font><br>
<p><font size="4">The order may need to vary by platform. On Linux, the DIspatch Swift overlay code lives in swift-corelibs-libdispatch/src/swift. So it works to build (1) Swift (2) libdispatch (both C and Swift) (3) Foundation. <br><br>--dave<br><br><graycol.gif></font><font size="4" color="#424282">Jordan Rose ---09/23/2016 06:34:46 PM---I think the right order to build things is: 1. libdispatch (C)</font><font size="4"><br></font><font color="#5F5F5F"><br>From: </font>Jordan Rose <<a href="mailto:jordan_rose@apple.com"><u><font color="#0000FF">jordan_rose@apple.com</font></u></a>><font color="#5F5F5F"><br>To: </font>David P Grove/Watson/IBM@IBMUS<font color="#5F5F5F"><br>Cc: </font>"Daniel A. Steffen" <<a href="mailto:dsteffen@apple.com"><u><font color="#0000FF">dsteffen@apple.com</font></u></a>>, swift-dev <<a href="mailto:swift-dev@swift.org"><u><font color="#0000FF">swift-dev@swift.org</font></u></a>>, swift-corelibs-dev <<a href="mailto:swift-corelibs-dev@swift.org"><u><font color="#0000FF">swift-corelibs-dev@swift.org</font></u></a>><font color="#5F5F5F"><br>Date: </font>09/23/2016 06:34 PM<font color="#5F5F5F"><br>Subject: </font>Re: [swift-dev] Swift CI PR builder dispatch linux failure<font color="#5F5F5F"><br>Sent by: </font><a href="mailto:jordan_rose@apple.com"><u><font color="#0000FF">jordan_rose@apple.com</font></u></a><p><hr width="100%" size="2" align="left" noshade><font size="4"><br><br></font><font size="5"><br>I think the right order to build things is:</font><font size="4"><br></font><font size="5"><br>1. libdispatch (C)<br>2. Swift (compiler + stdlib + Dispatch overlay)<br>3. Foundation</font><font size="4"><br></font><font size="5"><br>Otherwise we need to build Swift, then build libdispatch, then go back to "Swift" to build the overlay, and only finally get to Foundation.</font><font size="4"><br></font><font size="5"><br>Jordan</font><font size="4"><br></font><ul><ul><ul><ul><font size="5">On Sep 23, 2016, at 14:32, David P Grove via swift-dev <</font><a href="mailto:swift-dev@swift.org"><u><font size="5" color="#0000FF">swift-dev@swift.org</font></u></a><font size="5">> wrote:</font><p><font size="5">I'm playing with something. Should have a PR ready shortly.<br><br>--dave<br><br><br><graycol.gif></font><font size="5" color="#424282">"Daniel A. Steffen via swift-dev" ---09/23/2016 04:45:06 PM---I don’t know how these dependencies are expressed in CMake but it doesn’t seem very difficult to do</font><font size="4" color="#5F5F5F"><br><br>From: </font><font size="4">"Daniel A. Steffen via swift-dev" <</font><a href="mailto:swift-dev@swift.org"><u><font size="4" color="#0000FF">swift-dev@swift.org</font></u></a><font size="4">></font><font size="4" color="#5F5F5F"><br>To: </font><font size="4">Ted Kremenek <</font><a href="mailto:kremenek@apple.com"><u><font size="4" color="#0000FF">kremenek@apple.com</font></u></a><font size="4">></font><font size="4" color="#5F5F5F"><br>Cc: </font><font size="4">swift-dev <</font><a href="mailto:swift-dev@swift.org"><u><font size="4" color="#0000FF">swift-dev@swift.org</font></u></a><font size="4">></font><font size="4" color="#5F5F5F"><br>Date: </font><font size="4">09/23/2016 04:45 PM</font><font size="4" color="#5F5F5F"><br>Subject: </font><font size="4">Re: [swift-dev] Swift CI PR builder dispatch linux failure</font><font size="4" color="#5F5F5F"><br>Sent by: </font><a href="mailto:swift-dev-bounces@swift.org"><u><font size="4" color="#0000FF">swift-dev-bounces@swift.org</font></u></a><p><br><hr width="100%" size="2" align="left" noshade><font size="5"><br></font><font size="6"><br><br>I don’t know how these dependencies are expressed in CMake but it doesn’t seem very difficult to do so in the autotools buildsystem, we have<br><br>AC_ARG_WITH([swift-toolchain],<br>[AS_HELP_STRING([--with-swift-toolchain], [Specify path to Swift toolchain])],<br>[swift_toolchain_path=${withval}<br>AC_DEFINE(HAVE_SWIFT, 1, [Define if building for Swift])<br>SWIFTC="$swift_toolchain_path/bin/swiftc”<br><br>in configure.ac which ends up as a SWIFTC makefile variable, so as long as that argument is passed as an absolute path, it should work as a dependency in the build rules<br><br>$(abs_builddir)/swift/%.o: $(abs_srcdir)/swift/%.swift<br>$(SWIFTC) -frontend -c $(SWIFT_ABS_SRC_FILES) -primary-file $< \<br><br>Is there a JIRA ticket for this ? the IBM folks should probably be the ones making these changes since we still don’t have the whitelist in place for Apple contributors to do so…<br><br>Daniel</font><ul><ul><ul><ul><ul><ul><ul><ul><font size="6">On Sep 23, 2016, at 13:00, Ted Kremenek <</font><a href="mailto:kremenek@apple.com"><u><font size="6" color="#0000FF">kremenek@apple.com</font></u></a><font size="6">> wrote:<br><br>+ Daniel</font><b><font size="6"><br><br>Daniel</font></b><font size="6">: how hard would it be for the Dispatch project to be modified to add the swiftc binary used to build the project as a dependency?</font><ul><ul><ul><ul><ul><ul><ul><ul><font size="6">On Sep 23, 2016, at 12:55 PM, Ted Kremenek via swift-dev <</font><a href="mailto:swift-dev@swift.org"><u><font size="6" color="#0000FF">swift-dev@swift.org</font></u></a><font size="6">> wrote:<br><br>Dispatch is a separate project. There isn’t a dependency in the Dispatch project to tell it is building with a new compiler. The project would need to be modified to add a dependency on the swiftc binary being used to compile this project.</font><ul><ul><ul><ul><ul><ul><ul><ul><font size="6">On Sep 21, 2016, at 9:39 AM, Mishal Shah via swift-dev <</font><a href="mailto:swift-dev@swift.org"><u><font size="6" color="#0000FF">swift-dev@swift.org</font></u></a><font size="6">> wrote:<br><br>We should look into why it's not rebuilding dependencies. Do we need to fix CMake logic? Can you please file a bug?</font><font size="5"><br></font><font size="6"><br><br>Thanks,<br>Mishal Shah<br><br>On Sep 21, 2016, at 9:28 AM, Michael Gottesman <</font><a href="mailto:mgottesman@apple.com"><u><font size="6" color="#0000FF">mgottesman@apple.com</font></u></a><font size="6">> wrote:</font><ul><ul><ul><ul><ul><ul><ul><ul><font size="6">+CC Mishal</font><ul><ul><ul><ul><ul><ul><ul><ul><font size="6">On Sep 21, 2016, at 6:59 AM, David P Grove via swift-dev <</font><a href="mailto:swift-dev@swift.org"><u><font size="6" color="#0000FF">swift-dev@swift.org</font></u></a><font size="6">> wrote:</font><p><font size="4" face="Helvetica">I don't know how the PR jobs are setup, but the error suggests that they are trying to reuse too much of the workspace of previous runs.</font><font size="7" color="#FFFFFF" face="Helvetica"><br><br><</font><font size="7" face="Helvetica">unknown>:0: error: module file was created by an older version of the compiler; rebuild 'Dispatch' and try again: /home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/build/buildbot_linux/libdispatch-linux-x86_64/src/swift/Dispatch.o.~partial.swiftmodule<br><br>--dave</font><font size="4" face="Helvetica"><br><br><br><graycol.gif></font><font size="4" color="#424282" face="Helvetica">Ankit Aggarwal via swift-dev ---09/21/2016 03:08:58 AM---This has been consistently failing on PRs, can someone look into this: <unknown>:0: error: module fi</font><font size="5" color="#5F5F5F" face="Helvetica"><br><br>From: </font><font size="5" face="Helvetica">Ankit Aggarwal via swift-dev <</font><a href="mailto:swift-dev@swift.org"><u><font size="5" color="#0000FF" face="Helvetica">swift-dev@swift.org</font></u></a><font size="5" face="Helvetica">></font><font size="5" color="#5F5F5F" face="Helvetica"><br>To: </font><font size="5" face="Helvetica">swift-dev <</font><a href="mailto:swift-dev@swift.org"><u><font size="5" color="#0000FF" face="Helvetica">swift-dev@swift.org</font></u></a><font size="5" face="Helvetica">></font><font size="5" color="#5F5F5F" face="Helvetica"><br>Date: </font><font size="5" face="Helvetica">09/21/2016 03:08 AM</font><font size="5" color="#5F5F5F" face="Helvetica"><br>Subject: </font><font size="5" face="Helvetica">[swift-dev] Swift CI PR builder dispatch linux failure</font><font size="5" color="#5F5F5F" face="Helvetica"><br>Sent by: </font><a href="mailto:swift-dev-bounces@swift.org"><u><font size="5" color="#0000FF" face="Helvetica">swift-dev-bounces@swift.org</font></u></a><p><p><hr width="100%" size="2" align="left" noshade><font size="7" face="Helvetica"><br><br><br>This has been consistently failing on PRs, can someone look into this:</font><tt><font size="4" color="#FFFFFF"><br><br><unknown>:0: error: module file was created by an older version of the compiler; rebuild 'Dispatch' and try again: /home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/build/buildbot_linux/libdispatch-linux-x86_64/src/swift/Dispatch.o.~partial.swiftmodule</font></tt><tt><font size="4" color="#C0C5CE"><br>make[2]: *** [/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/build/buildbot_linux/libdispatch-linux-x86_64/src/swift/Dispatch.swiftmodule] Error 1<br>make[2]: Leaving directory `/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/build/buildbot_linux/libdispatch-linux-x86_64/src'<br>make[1]: *** [all] Error 2<br>make[1]: Leaving directory `/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/build/buildbot_linux/libdispatch-linux-x86_64/src'<br>make: *** [all-recursive] Error 1<br>/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 2, aborting<br>/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting</font></tt><u><font size="4" color="#0000FF" face="Helvetica"><br></font></u><u><font size="5" color="#0000FF"><br></font></u><u><font size="4" color="#0000FF"><br></font></u><a href="https://ci.swift.org/job/swift-package-manager-PR-Linux/497/console"><u><font size="7" color="#0000FF" face="Helvetica">https://ci.swift.org/job/swift-package-manager-PR-Linux/497/console</font></u></a><font size="5" face="Helvetica"><br><br>- Ankit</font><font size="7" face="Helvetica"> </font><font size="4" face="Helvetica"><br>[attachment "signature.asc" deleted by David P Grove/Watson/IBM] </font><tt><font size="4">_______________________________________________<br>swift-dev mailing list</font></tt><u><font size="4" color="#0000FF"><br></font></u><a href="mailto:swift-dev@swift.org"><tt><u><font size="4" color="#0000FF">swift-dev@swift.org</font></u></tt></a><u><font size="4" color="#0000FF"><br></font></u><a href="https://lists.swift.org/mailman/listinfo/swift-dev"><tt><u><font size="4" color="#0000FF">https://lists.swift.org/mailman/listinfo/swift-dev</font></u></tt></a><font size="6"><br></font><font size="4" face="Helvetica"><br><br><br>_______________________________________________<br>swift-dev mailing list</font><u><font size="4" color="#0000FF"><br></font></u><a href="mailto:swift-dev@swift.org"><u><font size="4" color="#0000FF" face="Helvetica">swift-dev@swift.org</font></u></a><u><font size="4" color="#0000FF"><br></font></u><a href="https://lists.swift.org/mailman/listinfo/swift-dev"><u><font size="4" color="#0000FF" face="Helvetica">https://lists.swift.org/mailman/listinfo/swift-dev</font></u></a></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul><font size="6">_______________________________________________<br>swift-dev mailing list</font><u><font size="4" color="#0000FF"><br></font></u><a href="mailto:swift-dev@swift.org"><u><font size="6" color="#0000FF">swift-dev@swift.org</font></u></a><u><font size="4" color="#0000FF"><br></font></u><a href="https://lists.swift.org/mailman/listinfo/swift-dev"><u><font size="6" color="#0000FF">https://lists.swift.org/mailman/listinfo/swift-dev</font></u></a></ul></ul></ul></ul></ul></ul></ul></ul><font size="6"><br>_______________________________________________<br>swift-dev mailing list</font><u><font size="4" color="#0000FF"><br></font></u><a href="mailto:swift-dev@swift.org"><u><font size="6" color="#0000FF">swift-dev@swift.org</font></u></a><u><font size="4" color="#0000FF"><br></font></u><a href="https://lists.swift.org/mailman/listinfo/swift-dev"><u><font size="6" color="#0000FF">https://lists.swift.org/mailman/listinfo/swift-dev</font></u></a></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul><tt><font size="5">_______________________________________________<br>swift-dev mailing list</font></tt><u><font size="4" color="#0000FF"><br></font></u><a href="mailto:swift-dev@swift.org"><tt><u><font size="5" color="#0000FF">swift-dev@swift.org</font></u></tt></a><u><font size="4" color="#0000FF"><br></font></u><a href="https://lists.swift.org/mailman/listinfo/swift-dev"><tt><u><font size="5" color="#0000FF">https://lists.swift.org/mailman/listinfo/swift-dev</font></u></tt></a><font size="5"><br><br></font><font size="4"><br></font><font size="5"><br>_______________________________________________<br>swift-dev mailing list</font><u><font size="4" color="#0000FF"><br></font></u><a href="mailto:swift-dev@swift.org"><u><font size="5" color="#0000FF">swift-dev@swift.org</font></u></a><u><font size="5" color="#0000FF"><br></font></u><a href="https://lists.swift.org/mailman/listinfo/swift-dev"><u><font size="5" color="#0000FF">https://lists.swift.org/mailman/listinfo/swift-dev</font></u></a></ul></ul></ul></ul><font size="4"><br><br></font></ul></ul><br><br><BR>
</body></html>