<div dir="ltr">Ah yep, I was wondering about relying on external services... will take a look.<div><br></div><div>SR 2675-2682 filed, will see if any of them are easy fixes (probably at least a few are just curl options)</div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, 17 Sep 2016 at 18:05 Pushkar N Kulkarni <<a href="mailto:pushkar.nk@in.ibm.com">pushkar.nk@in.ibm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><font face="Verdana,Arial,Helvetica,sans-serif" size="2"><div>Hi Mike, </div><div><br></div><div>The tests look great and exhaustive to me. I just wish to mention here that we've experienced hangs in CI tests while connecting to some external URLs in the past (you can see a few tests commented out in the current TestNSURLSession for that reason). It was then recommended, by Tony, that we have a <a href="https://github.com/apple/swift-corelibs-foundation/pull/613" title="https://github.com/apple/swift-corelibs-foundation/pull/613" target="_blank">loopback server to test URLSession</a>. Having said that, I can't be sure that the httpbin urls, that you use, will cause the same issues :-)</div><div><br></div><div>Also, it'd be great if you could file JIRA reports/PRs for the failures you see. Thanks!</div><div><font face="Verdana,Arial,Helvetica,sans-serif" size="2"><font><font><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr" style="font-style:normal"><br><font face="Sans Serif, Verdana, Arial, Helvetica, sans-serif">Pushkar N Kulkarni,</font></div>
<div dir="ltr" style="font-style:normal"><font face="Sans Serif, Verdana, Arial, Helvetica, sans-serif">IBM Runtimes</font></div><div dir="ltr" style="font-style:normal"><font face="Sans Serif, Verdana, Arial, Helvetica, sans-serif"><br></font></div><div dir="ltr"><font face="serif, Times New Roman, Times, serif"><i>Simplicity is prerequisite for reliability - Edsger W. Dijkstra</i></font></div>
<div dir="ltr" style="font-style:normal;font-size:10.5pt;font-family:Arial"><br></div></div></div></div></font></font></font></div><br><br><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2" color="#000000"><font color="#990099"><a href="mailto:-----swift-corelibs-dev-bounces@swift.org" target="_blank">-----swift-corelibs-dev-bounces@swift.org</a> wrote: -----</font><div style="padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px">To: swift-corelibs-dev <<a href="mailto:swift-corelibs-dev@swift.org" target="_blank">swift-corelibs-dev@swift.org</a>><br>From: Mike Ferenduros via swift-corelibs-dev <u></u><br>Sent by: <a href="mailto:swift-corelibs-dev-bounces@swift.org" target="_blank">swift-corelibs-dev-bounces@swift.org</a><br>Date: 09/17/2016 05:34PM<br>Subject: [swift-corelibs-dev] URLSession tests</div></div></font></font><font face="Verdana,Arial,Helvetica,sans-serif" size="2"><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2" color="#000000"><div style="padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px"><br><br><div dir="ltr">Hello!<div>I was looking for a way to contribute, and I ran into a URLSession issue, so I started fleshing out the test module for it:</div><div><a href="https://github.com/mike-ferenduros/swift-corelibs-foundation/blob/more-urlsession-tests/TestFoundation/TestNSURLSession.swift" target="_blank">https://github.com/mike-ferenduros/swift-corelibs-foundation/blob/more-urlsession-tests/TestFoundation/TestNSURLSession.swift</a><br></div><div><br></div><div>It doesn't cover all of the API yet, but it does trap a bunch of issues. But it's my first time contributing to a large, public project so I'm a bit nervous about ploughing ahead with it... is there any chance someone could take a quick look and let me know if I'm on the right track, or need to fundamentally change or scrap it?</div><div><br></div><div>Also, I'm not sure about the etiquette of submitting failing tests (of which there are quite a few :p )</div><div><br></div></div></div></div></font></font><font face="Verdana,Arial,Helvetica,sans-serif" size="2"><font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2" color="#000000"><div style="padding-left:5px"><div style="padding-right:0px;padding-left:5px;border-left:solid black 2px"><div><font face="Courier New,Courier,monospace" size="3">_______________________________________________<br>swift-corelibs-dev mailing list<br><a href="mailto:swift-corelibs-dev@swift.org" target="_blank">swift-corelibs-dev@swift.org</a><br><a href="https://lists.swift.org/mailman/listinfo/swift-corelibs-dev" target="_blank">https://lists.swift.org/mailman/listinfo/swift-corelibs-dev</a><br></font></div><u></u></div></div></font></font><br>
</blockquote></div>