<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Tossed up a PR for correcting this uniformly without needing alteration of the #if statements</div><div class=""><br class=""></div><div class=""><a href="https://github.com/apple/swift-corelibs-foundation/pull/584" class="">https://github.com/apple/swift-corelibs-foundation/pull/584</a></div><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 23, 2016, at 8:42 AM, Chris Bailey via swift-corelibs-dev <<a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><font size="2" face="sans-serif" class="">We're currently making the last few changes
which should mean that Dispatch always builds on Linux if your using Foundation,
and as Dispatch is already there on Darwin, it should mean we can remove
the condition statements entirely. </font>
<br class="">
<br class=""><font size="2" face="sans-serif" class="">Chris<br class="">
</font>
<br class="">
<br class="">
<br class="">
<br class=""><font size="1" color="#5f5f5f" face="sans-serif" class="">From:
</font><font size="1" face="sans-serif" class="">Luke Howard via swift-corelibs-dev
<<a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a>></font>
<br class=""><font size="1" color="#5f5f5f" face="sans-serif" class="">To:
</font><font size="1" face="sans-serif" class="">Tony Parker via swift-corelibs-dev
<<a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a>></font>
<br class=""><font size="1" color="#5f5f5f" face="sans-serif" class="">Date:
</font><font size="1" face="sans-serif" class="">23/08/2016 08:55</font>
<br class=""><font size="1" color="#5f5f5f" face="sans-serif" class="">Subject:
</font><font size="1" face="sans-serif" class="">Re: [swift-corelibs-dev]
f8c3fe6c breaks on Darwin</font>
<br class=""><font size="1" color="#5f5f5f" face="sans-serif" class="">Sent by:
</font><font size="1" face="sans-serif" class=""><a href="mailto:swift-corelibs-dev-bounces@swift.org" class="">swift-corelibs-dev-bounces@swift.org</a></font>
<br class="">
<hr noshade="" class="">
<br class="">
<br class="">
<br class=""><font size="3" class="">Also, the NSData test is broken on Darwin when libdispatch
is enabled – possibly the system DispatchData is being pulled in and something
funny happens, this seems to work around it but I’m not sure if it is
the correct fix:</font>
<br class="">
<br class=""><font size="2" color="#9f9fff" face="Consolas" class=""><b class="">+++ b/Foundation/NSData.swift</b></font>
<br class=""><font size="2" color="#00c1c2" face="Consolas" class="">@@ -228,7 +228,7 @@</font><font size="2" color="#9f9fff" face="Consolas" class="">
open class NSData : NSObject, NSCopying, NSMutableCopying, NSSecureCoding
{</font>
<br class=""><font size="2" color="#9f9fff" face="Consolas" class=""> }</font>
<br class=""><font size="2" color="#9f9fff" face="Consolas" class=""> </font>
<br class=""><font size="2" color="#9f9fff" face="Consolas" class=""> open
override func isEqual(_ value: Any?) -> Bool {</font>
<br class=""><font size="2" color="#bf4100" face="Consolas" class="">-#if DEPLOYMENT_ENABLE_LIBDISPATCH</font>
<br class=""><font size="2" color="#00c200" face="Consolas" class="">+#if DEPLOYMENT_ENABLE_LIBDISPATCH
&& !os(OSX)</font>
<br class=""><font size="2" color="#9f9fff" face="Consolas" class="">
if let data = value as? DispatchData {</font>
<br class=""><font size="2" color="#9f9fff" face="Consolas" class="">
if data.count != length {</font>
<br class=""><font size="2" color="#9f9fff" face="Consolas" class="">
return false</font>
<br class="">
<br class="">
<br class=""><font size="3" class="">On 23 Aug 2016, at 5:46 PM, Luke Howard via swift-corelibs-dev
<</font><a href="mailto:swift-corelibs-dev@swift.org" class=""><font size="3" color="blue" class=""><u class="">swift-corelibs-dev@swift.org</u></font></a><font size="3" class="">>
wrote:</font>
<br class="">
<br class=""><font size="3" class="">Enabling libdispatch seems to break the tests on Darwin
because DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project
build flags (both for the C/Swift compilers).</font>
<br class="">
<br class=""><font size="3" class="">--</font>
<br class=""><a href="http://www.lukehoward.com/" class=""><font size="3" color="blue" class=""><u class="">www.lukehoward.com</u></font></a><font size="3" color="blue" class=""><u class=""><br class="">
</u></font><a href="http://soundcloud.com/lukehoward" class=""><font size="3" color="blue" class=""><u class="">soundcloud.com/lukehoward</u></font></a>
<br class=""><font size="3" class="">_______________________________________________<br class="">
swift-corelibs-dev mailing list</font><font size="3" color="blue" class=""><u class=""><br class="">
</u></font><a href="mailto:swift-corelibs-dev@swift.org" class=""><font size="3" color="blue" class=""><u class="">swift-corelibs-dev@swift.org</u></font></a><font size="3" class=""><br class="">
</font><a href="https://lists.swift.org/mailman/listinfo/swift-corelibs-dev" class=""><font size="3" class="">https://lists.swift.org/mailman/listinfo/swift-corelibs-dev</font></a>
<br class="">
<br class=""><font size="3" class="">--</font>
<br class=""><a href="http://www.lukehoward.com/" class=""><font size="3" color="blue" class=""><u class="">www.lukehoward.com</u></font></a><font size="3" class=""><br class="">
<a href="http://soundcloud.com/lukehoward" class="">soundcloud.com/lukehoward</a></font>
<br class=""><tt class=""><font size="2" class="">_______________________________________________<br class="">
swift-corelibs-dev mailing list<br class="">
<a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a><br class="">
</font></tt><a href="https://lists.swift.org/mailman/listinfo/swift-corelibs-dev" class=""><tt class=""><font size="2" class="">https://lists.swift.org/mailman/listinfo/swift-corelibs-dev</font></tt></a><tt class=""><font size="2" class=""><br class="">
</font></tt>
<br class="">
<br class="">
_______________________________________________<br class="">swift-corelibs-dev mailing list<br class=""><a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-corelibs-dev<br class=""></div></blockquote></div><br class=""></body></html>