<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div>I agree with Stephan, NSIndexPath performance is important and we should avoid the overhead of allocating/freeing an array for the common case. Instead of just always wrapping NSIndexPath, maybe we should just switch the internal representation to something like<br></div>
<div><br></div>
<div>enum Indices {<br></div>
<div> case one(Int)<br></div>
<div> case two(Int, Int)<br></div>
<div> // case three?<br></div>
<div> case many([Int])<br></div>
<div>}<br></div>
<div><br></div>
<div>Yeah it complicates the methods a bit, and we'd have to have a custom index instead of just using Array's index, but it avoids heap allocation for the extremely common case of a 2-element index path (it's so common, I don't think I've <i>ever</i> seen an NSIndexPath that didn't contain exactly 2 indices).</div>
<div><br></div>
<div>-Kevin Ballard</div>
<div><br></div>
<div>On Tue, Aug 2, 2016, at 04:24 AM, Stephan Tolksdorf via swift-corelibs-dev wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div>Tony,<br></div>
<div><br></div>
<div>I understand why you'd ideally want to have a real-world benchmark to guide performance optimisations, but if you require that for every performance-related change, you set a very high bar, and that bar will probably have the effect of biasing performance downwards, since if there is no existing benchmark, changes that worsen performance might not get flagged.<br></div>
<div><br></div>
<div>The fact that NSIndexPath got the tagged pointer treatment probably indicates that its implementation has a non-negligible effect on performance (see also <a href="https://twitter.com/Catfish_Man/status/393249511075639296">https://twitter.com/Catfish_Man/status/393249511075639296</a>). <br></div>
<div><br></div>
<div><div>The current IndexPath implementation in terms of an Int array clearly introduces unnecessary overhead in ObjC interop scenarios, so unless this implementation of IndexPath has some benefit I don't understand, I'd argue that it should be replaced with a straightforward wrapper around an NSIndexPath value.<br></div>
</div>
<div><br></div>
<div>- Stephan<br></div>
</div>
<div><div><br></div>
<div defang_data-gmailquote="yes"><div>On 2 August 2016 at 12:12, Tony Parker <span dir="ltr"><<a href="mailto:anthony.parker@apple.com">anthony.parker@apple.com</a>></span> wrote:<br></div>
<blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204, 204, 204);border-left-style:solid;padding-left:1ex;" defang_data-gmailquote="yes"><div style="word-wrap:break-word;"><div>Hi Stephan,<br></div>
<div><div><br></div>
<div><div><span></span><br></div>
<blockquote type="cite"><div><span>On Aug 2, 2016, at 6:04 PM, Stephan Tolksdorf <<a href="mailto:st@quanttec.com">st@quanttec.com</a>> wrote:</span><br></div>
<div><span><br></span></div>
<div><div dir="ltr"><div><span>Hi Parker,</span><br></div>
<div><span></span><br></div>
<div><span>I noticed the IndexPath overhead when I investigated why a Swift 3 implementation of UICollectionViewLayout.layoutAttributesForElementsInRect spent more time in malloc, free and related methods, but I don't have a benchmark.</span><br></div>
<div><span></span><br></div>
<div><span>Is it important that IndexPath uses native Swift refcounting? It seems to me that this type is mainly used in ObjC interop code. In native Swift code I would always try to avoid using a dynamically sized, heap allocated array as a data structure index. If NSIndexPath can't be bridged to a native Swift type without introducing additional overhead, then maybe it shouldn't be bridged at all?</span><br></div>
<div><span></span><br></div>
<div><span>- Stephan</span><br></div>
</div>
</div>
</blockquote><div><span></span><br></div>
<div><span></span><br></div>
<div><span></span><br></div>
<div>I do think it is likely we could figure out some improvements here, but I’d like to start with a concrete test (and something that is representative of real world use cases). If it’s possible to extract something out of what you’ve already done, that would be really helpful. We can also file a bug on <a href="http://bugs.swift.org">bugs.swift.org</a> as a call for help designing a better perf test suite (we need this for all of the types, frankly).<br></div>
<div><br></div>
<div>Once we know we’re measuring the right thing, there are all kinds of interesting things we can do. If (when?) we have ABI stability in Swift 4, we may be able to also change the ObjC Foundation.framework to better cooperate with the Swift side, as we’ll be able to tie the current overlay code to a specific OS instead of having to run back several releases.<br></div>
<div><br></div>
<div>Thanks,<br></div>
<div>- Tony<br></div>
</div>
<div><span></span><br></div>
<div><div><span><br></span></div>
<blockquote type="cite"><div><div dir="ltr"><div><span></span><br></div>
<div><div defang_data-gmailquote="yes"><div><span>On 2 August 2016 at 11:09, Tony Parker <span dir="ltr"><<a href="mailto:anthony.parker@apple.com">anthony.parker@apple.com</a>></span> wrote:<br></span></div>
<blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204, 204, 204);border-left-style:solid;padding-left:1ex;" defang_data-gmailquote="yes"><div><span>Hi Stephan,<br> <br> Do you have some benchmarks that you could share? That would help us focus performance work in the right area.<br> <br> I know that 2-item IndexPaths are super common with UIKit collection view and friends, so we may just want to special case those. Unfortunately, NSIndexPath is not abstract, so subclassing it in the same way that we do for a few of the other bridged types (to use native Swift refcounting) is not easy. On the other hand, the ObjC implementation does use tagged pointers, so some NSIndexPaths are really cheap to create.<br> <br> - Tony<br> </span></div>
<div><div><span><br>> On Aug 1, 2016, at 11:44 PM, Stephan Tolksdorf via swift-corelibs-dev <<a href="mailto:swift-corelibs-dev@swift.org">swift-corelibs-dev@swift.org</a>> wrote:<br> ><br> > Hi,<br> ><br> > IndexPath is currently implemented using an [Int] array that is bridged to an NSIndexPath only on demand. Since IndexPath values are primarily used together with Objective-C APIs, wouldn't it be better to implement IndexPath directly as an NSIndexPath wrapper, in order to avoid the overhead of temporary array instances?<br> ><br> > - Stephan</span></div>
</div>
<div><span>> _______________________________________________<br> > swift-corelibs-dev mailing list<br> > <a href="mailto:swift-corelibs-dev@swift.org">swift-corelibs-dev@swift.org</a><br> > <a href="https://lists.swift.org/mailman/listinfo/swift-corelibs-dev">https://lists.swift.org/mailman/listinfo/swift-corelibs-dev</a><br> </span></div>
</blockquote></div>
<div><span></span><br></div>
</div>
</div>
</div>
</blockquote></div>
<div><span></span><br></div>
</div>
</div>
</blockquote></div>
</div>
<div><u>_______________________________________________</u><br></div>
<div>swift-corelibs-dev mailing list<br></div>
<div><a href="mailto:swift-corelibs-dev@swift.org">swift-corelibs-dev@swift.org</a><br></div>
<div><a href="https://lists.swift.org/mailman/listinfo/swift-corelibs-dev">https://lists.swift.org/mailman/listinfo/swift-corelibs-dev</a><br></div>
</blockquote><div><br></div>
</body>
</html>