<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Alexander,<div class=""><br class=""></div><div class="">Small incremental changes is usually a good approach.</div><div class=""><br class=""></div><div class="">As for adding tests first, we can do that but we just need to make sure they don’t fail the build. What approach would you have in mind for that?</div><div class=""><br class=""></div><div class="">- Tony</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 22, 2016, at 1:37 AM, Alexander Alemayhu via swift-corelibs-dev <<a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Hei Everyone,</div><div class=""><br class=""></div><div class="">I have been reading the documentation the last couple of days and have been</div><div class="">thinking that it would make more sense to try to tackle this via several</div><div class="">incremental changes vs a large pull request some time in the future. What do you</div><div class="">think?</div><div class=""><br class=""></div><div class="">If that is preferred, I would purpose as a first step to introduce [tests][1]</div><div class="">for NSFileHandle. Adding tests in general sounds like a good idea, but I am not</div><div class="">sure how one should test NSFileHandle. Would it be a good starting point to add</div><div class="">tests for the methods used by [plutil][2]?</div><div class=""><br class=""></div><div class="">Thanks.</div><div class=""><br class=""></div><div class="">[1]: <a href="https://github.com/apple/swift-corelibs-foundation/blob/master/TestFoundation/main.swift" class="">https://github.com/apple/swift-corelibs-foundation/blob/master/TestFoundation/main.swift</a></div><div class=""><br class=""></div><div class="">[2]: <a href="https://github.com/apple/swift-corelibs-foundation/blob/master/Tools/plutil/main.swift" class="">https://github.com/apple/swift-corelibs-foundation/blob/master/Tools/plutil/main.swift</a></div><div class=""><br class=""></div><div class="gmail_extra">-- <br class=""><div class="gmail_signature">Mit freundlichen Grüßen<br class=""><br class="">Alexander Alemayhu</div>
</div></div>
_______________________________________________<br class="">swift-corelibs-dev mailing list<br class=""><a href="mailto:swift-corelibs-dev@swift.org" class="">swift-corelibs-dev@swift.org</a><br class="">https://lists.swift.org/mailman/listinfo/swift-corelibs-dev<br class=""></div></blockquote></div><br class=""></div></body></html>