[swift-corelibs-dev] CharacterSet Issues

Tony Parker anthony.parker at apple.com
Wed Mar 29 14:43:52 CDT 2017


Hi David,

Philippe recently put up a PR for these changes again to the overlay and its tests, but I think we’re stuck on some issue where the iPhone sim test is failing and we’re not sure why (https://github.com/apple/swift/pull/8283 <https://github.com/apple/swift/pull/8283>).

On the darwin side, these fixes required a change in CoreFoundation, which we put into the recently-released 10.12.4 and 10.3 and family. I think I already merged the CFCharacterSet.c change itself to swift-corelibs-foundation.

- Tony

> On Mar 29, 2017, at 2:50 AM, David Dunn via swift-corelibs-dev <swift-corelibs-dev at swift.org> wrote:
> 
> Hey, 
> 
> I noticed there's a lot of bugs within CharacterSet at the moment some of which I've started to look at. In particular I've been looking at SR-3485 (CharacterSet.isSuperset(of:) returns wrong result on Linux), alongside this I've noticed there's various others such as SR-3282, SR-3825 and SR-2956 to name a few.
> 
> I've tracked the SR-3485 issue down into the CoreFoundation code and just need to spend some time understanding what the C code is doing exactly and why it's returning the incorrect value. 
> 
> During my investigation into SR-3485 I stumbled upon SR-3311 where Philippe Hausler mentioned Tony Parker was working on a set of fixes for the CharacterSet issues, I found more information about this on a PR (#6044 <https://github.com/apple/swift/pull/6044>) against apple/swift, I also found Tony's branch <https://github.com/parkera/swift/tree/parkera/characterset_refactor> for the refactor of CharacterSet. So firstly I was wondering if there has been any update on this recently? And is this a planned fix for all of the current issues in CharacterSet? 
> 
> Thanks, 
> David
> _______________________________________________
> swift-corelibs-dev mailing list
> swift-corelibs-dev at swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-corelibs-dev/attachments/20170329/e676786d/attachment.html>


More information about the swift-corelibs-dev mailing list