<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div><span></span></div><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div><span></span></div><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div><br></div><div>On Mar 8, 2017, at 22:34, Ankit Aggarwal &lt;<a href="mailto:ankit_aggarwal@apple.com">ankit_aggarwal@apple.com</a>&gt; wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>&nbsp;<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div style="word-wrap:break-word"><div><span class="m_3392127985484131722gmail-"></span><div>+1, although I don’t know why we're supporting this:</div><div><pre style="box-sizing:border-box;font-family:sfmono-regular,consolas,'liberation mono',menlo,courier,monospace;font-size:13.600000381469727px;margin-top:0px;margin-bottom:0px;line-height:1.45;word-wrap:normal;padding:16px;overflow:auto;background-color:rgb(246,248,250);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;word-break:normal;color:rgb(36,41,46)"><span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c" style="box-sizing:border-box;color:rgb(150,152,150)"><span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c" style="box-sizing:border-box">//</span> 1.5.8 ..&lt; 2.0.0</span>
<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c" style="box-sizing:border-box;color:rgb(150,152,150)"></span>.<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c1" style="box-sizing:border-box;color:rgb(0,134,179)">package</span>(<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c1" style="box-sizing:border-box;color:rgb(0,134,179)">url</span>: <span class="m_3392127985484131722gmail-m_-6685159868071850230pl-s" style="box-sizing:border-box;color:rgb(24,54,145)"><span class="m_3392127985484131722gmail-m_-6685159868071850230pl-pds" style="box-sizing:border-box">"</span>/SwiftyJSON<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-pds" style="box-sizing:border-box">"</span></span>, <span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c1" style="box-sizing:border-box;color:rgb(0,134,179)">from</span>: <span class="m_3392127985484131722gmail-m_-6685159868071850230pl-s" style="box-sizing:border-box;color:rgb(24,54,145)"><span class="m_3392127985484131722gmail-m_-6685159868071850230pl-pds" style="box-sizing:border-box">"</span>1.5.8<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-pds" style="box-sizing:border-box">"</span></span>),</pre><div>when, at least as far as I can tell, this:</div><div><pre style="box-sizing:border-box;font-family:sfmono-regular,consolas,'liberation mono',menlo,courier,monospace;font-size:13.600000381469727px;margin-top:0px;margin-bottom:0px;line-height:1.45;word-wrap:normal;padding:16px;overflow:auto;background-color:rgb(246,248,250);border-top-left-radius:3px;border-top-right-radius:3px;border-bottom-right-radius:3px;border-bottom-left-radius:3px;word-break:normal;color:rgb(36,41,46)"><span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c" style="box-sizing:border-box;color:rgb(150,152,150)"><span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c" style="box-sizing:border-box">//</span> 1.5.8 ..&lt; 2.0.0</span>
<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c" style="box-sizing:border-box;color:rgb(150,152,150)"></span>.<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c1" style="box-sizing:border-box;color:rgb(0,134,179)">package</span>(<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c1" style="box-sizing:border-box;color:rgb(0,134,179)">url</span>: <span class="m_3392127985484131722gmail-m_-6685159868071850230pl-s" style="box-sizing:border-box;color:rgb(24,54,145)"><span class="m_3392127985484131722gmail-m_-6685159868071850230pl-pds" style="box-sizing:border-box">"</span>/SwiftyJSON<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-pds" style="box-sizing:border-box">"</span></span>, .<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-c1" style="box-sizing:border-box;color:rgb(0,134,179)">uptoNextMajor</span>(<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-s" style="box-sizing:border-box;color:rgb(24,54,145)"><span class="m_3392127985484131722gmail-m_-6685159868071850230pl-pds" style="box-sizing:border-box">"</span>1.5.8<span class="m_3392127985484131722gmail-m_-6685159868071850230pl-pds" style="box-sizing:border-box">"</span></span>)),</pre><div>does the same thing, and the spelling is, at least to me, clearer as well. Dunno, maybe the “from” version is a term of art that I’m just not familiar with.</div></div></div><div><br></div></div></div></blockquote><div><br></div></div><div>Hi David,</div><div><br></div><div>Thank you for the review.&nbsp;</div><div><br></div><div>It is true that `from` and `.uptoNextMajor` are exactly same. We think that the most widely used requirement will be `.uptoNextMajor`, so we wanted to provide a shorthand for it.</div></div></div>
</div></blockquote><br><div>Ok, I just wanted to make sure having both spellings was intentional. I've been trying to think of a shorthand that's clearer, but haven't really come up with anything.</div><div><br></div><div>Seems like we're fighting English's grammar... With the non-shorthand spelling, the "normal" way to write that would have the version first, followed by the modifier. Adapted to pseudo-code, it would be `1.5.8.uptoNextMajor()`, which Swift currently can't support. And "from" is typically followed by "to" or "through", which makes the shorthand kinda odd as well.&nbsp;</div><div><br></div><div>Sorry, I should've noticed this during the discussion thread. Since this the review thread, though, I want to make it clear that I'm still +1, and think this spelling issue (to the extent that it is one) isn't worth derailing the proposal.</div><div><br></div><div>- Dave Sweeris&nbsp;</div></div></div></body></html>