<html><body><p>Thanks again for your help Daniel. I think I found the issue - for some reason the option is not read in properly on s390x. I'll debug from there.<br><br>Regards,<br><br>Vivian Kong<br>Software Developer<br>IBM Canada Toronto Lab<br><br><img width="16" height="16" src="cid:1__=8FBB0A82DFF550428f9e8a93df938690918c8FB@" border="0" alt="Inactive hide details for Daniel Dunbar ---2016/08/16 01:58:30 PM---> On Aug 16, 2016, at 10:54 AM, Vivian Kong <vivkong@ca.ibm"><font color="#424282">Daniel Dunbar ---2016/08/16 01:58:30 PM---> On Aug 16, 2016, at 10:54 AM, Vivian Kong <vivkong@ca.ibm.com> wrote: ></font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Daniel Dunbar <daniel_dunbar@apple.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">Vivian Kong/Toronto/IBM@IBMCA</font><br><font size="2" color="#5F5F5F">Cc: </font><font size="2">Daniel Dunbar <daniel@zuster.org>, "swift-build-dev@swift.org" <swift-build-dev@swift.org></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">2016/08/16 01:58 PM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [swift-build-dev] Test failures on s390x</font><br><font size="2" color="#5F5F5F">Sent by: </font><font size="2">daniel_dunbar@apple.com</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br>
<ul><ul><font size="4">On Aug 16, 2016, at 10:54 AM, Vivian Kong <</font><a href="mailto:vivkong@ca.ibm.com"><u><font size="4" color="#0000FF">vivkong@ca.ibm.com</font></u></a><font size="4">> wrote:</font><br>
<p><font size="4">Sorry just want to be clear, can you elaborate what swift-test should be doing? It's trying to build with this command?</font></ul></ul><font size="4">The *test* in question is trying to run `swift-test --version`, which should do nothing other than print its own version number.</font><ul><ul><font size="4" face=".SF NS Text">/localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swift-build-tool -f /localbox/vivkong/swift3/swiftpm/.build/debug.yaml test<br><br>Does that do that every time swift-test is being executed?</font></ul></ul><font size="4">Yes, during normal operation (when using the tool to actually run tests, it always builds them first).</font><br><br><font size="4"> - Daniel</font><ul><ul><font size="4"><br>Regards,<br><br>Vivian Kong<br>Software Developer<br>IBM Canada Toronto Lab<br><br><graycol.gif></font><font size="4" color="#424282">Daniel Dunbar ---2016/08/16 01:21:41 PM---> On Aug 16, 2016, at 10:19 AM, Vivian Kong <</font><a href="mailto:vivkong@ca.ibm.com"><u><font size="4" color="#0000FF">vivkong@ca.ibm.com</font></u></a><font size="4" color="#424282">> wrote: ></font><font size="4"><br></font><font color="#5F5F5F"><br>From: </font>Daniel Dunbar <<a href="mailto:daniel_dunbar@apple.com"><u><font color="#0000FF">daniel_dunbar@apple.com</font></u></a>><font color="#5F5F5F"><br>To: </font>Vivian Kong/Toronto/IBM@IBMCA<font color="#5F5F5F"><br>Cc: </font>Daniel Dunbar <<a href="mailto:daniel@zuster.org"><u><font color="#0000FF">daniel@zuster.org</font></u></a>>, "<a href="mailto:swift-build-dev@swift.org"><u><font color="#0000FF">swift-build-dev@swift.org</font></u></a>" <<a href="mailto:swift-build-dev@swift.org"><u><font color="#0000FF">swift-build-dev@swift.org</font></u></a>><font color="#5F5F5F"><br>Date: </font>2016/08/16 01:21 PM<font color="#5F5F5F"><br>Subject: </font>Re: [swift-build-dev] Test failures on s390x<font color="#5F5F5F"><br>Sent by: </font><a href="mailto:daniel_dunbar@apple.com"><u><font color="#0000FF">daniel_dunbar@apple.com</font></u></a><p><hr width="100%" size="2" align="left" noshade><font size="4"><br><br></font><ul><ul><ul><ul><font size="5">On Aug 16, 2016, at 10:19 AM, Vivian Kong <</font><a href="mailto:vivkong@ca.ibm.com"><u><font size="5" color="#0000FF">vivkong@ca.ibm.com</font></u></a><font size="5">> wrote:</font><p><font size="5">Thanks for clarifying! I just checked and my swift-test executable seems to have the correct RPATH (Foundation and XCTest paths are there).<br><br>And yes I didn't understand why when I execute swift-test it is trying to compile. Let me do a clean SwiftPM build again and check the log.</font></ul></ul></ul></ul><font size="5"><br>That is normal behavior for the `swift-test` tool. It is just not normal behavior when run with `--version`.</font><font size="4"><br></font><font size="5"><br>- Daniel</font><ul><ul><ul><ul><font size="5"><br>Regards,<br><br>Vivian Kong<br>Software Developer<br>IBM Canada Toronto Lab<br><br><graycol.gif></font><font size="5" color="#424282">Daniel Dunbar ---2016/08/16 01:10:41 PM---I wasn't precise enough, we actually use RUNPATH currently. Here is what I see for a local build on</font><font size="4" color="#5F5F5F"><br><br>From: </font><font size="4">Daniel Dunbar <</font><a href="mailto:daniel_dunbar@apple.com"><u><font size="4" color="#0000FF">daniel_dunbar@apple.com</font></u></a><font size="4">></font><font size="4" color="#5F5F5F"><br>To: </font><font size="4">Vivian Kong/Toronto/IBM@IBMCA</font><font size="4" color="#5F5F5F"><br>Cc: </font><font size="4">Daniel Dunbar <</font><a href="mailto:daniel@zuster.org"><u><font size="4" color="#0000FF">daniel@zuster.org</font></u></a><font size="4">>, "</font><a href="mailto:swift-build-dev@swift.org"><u><font size="4" color="#0000FF">swift-build-dev@swift.org</font></u></a><font size="4">" <</font><a href="mailto:swift-build-dev@swift.org"><u><font size="4" color="#0000FF">swift-build-dev@swift.org</font></u></a><font size="4">></font><font size="4" color="#5F5F5F"><br>Date: </font><font size="4">2016/08/16 01:10 PM</font><font size="4" color="#5F5F5F"><br>Subject: </font><font size="4">Re: [swift-build-dev] Test failures on s390x</font><font size="4" color="#5F5F5F"><br>Sent by: </font><a href="mailto:daniel_dunbar@apple.com"><u><font size="4" color="#0000FF">daniel_dunbar@apple.com</font></u></a><br><br><hr width="100%" size="2" align="left" noshade><font size="5"><br></font><font size="6"><br><br>I wasn't precise enough, we actually use RUNPATH currently. Here is what I see for a local build on Ubuntu 15.10:</font><font size="4" color="#0220B3"><br><br>~/public/swift-project/swiftpm$ </font><b><font size="4">objdump -x ../build/Ninja-ReleaseAssert/swiftpm-linux-x86_64/debug/swift-test | grep RUNPATH</font></b><font size="4"> <br>RUNPATH /home/ddunbar/public/swift-project/build/Ninja-ReleaseAssert/swift-linux-x86_64/lib/swift/linux:$ORIGIN/../lib/swift/linux:/home/ddunbar/public/swift-project/build/Ninja-ReleaseAssert/foundation-linux-x86_64/Foundation:/home/ddunbar/public/swift-project/build/Ninja-ReleaseAssert/xctest-linux-x86_64:$ORIGIN </font><font size="6"><br><br>Note the Foundation and XCTest paths there.<br><br>Actually -- I just realized what is going on, it is something completely different.<br><br>Your `swift-test --version` command appears to be, for some reason or other, actually trying to execute the tests (instead of just printing the version). It shouldn't be doing that; is it possible there is a miscompile of swift-test here?<br><br>- Daniel</font><ul><ul><ul><ul><ul><ul><ul><ul><font size="6">On Aug 16, 2016, at 10:03 AM, Vivian Kong <</font><a href="mailto:vivkong@ca.ibm.com"><u><font size="6" color="#0000FF">vivkong@ca.ibm.com</font></u></a><font size="6">> wrote:</font><p><font size="6">Sorry was having lunch =P<br><br>Makes sense! I tried doing <br><br>objdump -x /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swiftc | grep RPATH<br><br>but it returns nothing.<br><br>I did the same thing on my build on x86_64 and got the same result. <br><br>Regards,<br><br>Vivian Kong<br>Software Developer<br>IBM Canada Toronto Lab<br><br><graycol.gif></font><font size="6" color="#424282">Daniel Dunbar ---2016/08/16 12:43:38 PM---Hi Vivian, Did you see my follow up?</font><font size="5" color="#5F5F5F"><br><br>From: </font><font size="5">Daniel Dunbar <</font><a href="mailto:daniel_dunbar@apple.com"><u><font size="5" color="#0000FF">daniel_dunbar@apple.com</font></u></a><font size="5">></font><font size="5" color="#5F5F5F"><br>To: </font><font size="5">Vivian Kong/Toronto/IBM@IBMCA</font><font size="5" color="#5F5F5F"><br>Cc: </font><font size="5">Daniel Dunbar <</font><a href="mailto:daniel@zuster.org"><u><font size="5" color="#0000FF">daniel@zuster.org</font></u></a><font size="5">>, "</font><a href="mailto:swift-build-dev@swift.org"><u><font size="5" color="#0000FF">swift-build-dev@swift.org</font></u></a><font size="5">" <</font><a href="mailto:swift-build-dev@swift.org"><u><font size="5" color="#0000FF">swift-build-dev@swift.org</font></u></a><font size="5">></font><font size="5" color="#5F5F5F"><br>Date: </font><font size="5">2016/08/16 12:43 PM</font><font size="5" color="#5F5F5F"><br>Subject: </font><font size="5">Re: [swift-build-dev] Test failures on s390x</font><font size="5" color="#5F5F5F"><br>Sent by: </font><a href="mailto:daniel_dunbar@apple.com"><u><font size="5" color="#0000FF">daniel_dunbar@apple.com</font></u></a><p><p><hr width="100%" size="2" align="left" noshade><font size="7"><br><br><br>Hi Vivian,<br><br>Did you see my follow up?<br><br>- Daniel</font><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><font size="7">On Aug 16, 2016, at 8:54 AM, Vivian Kong via swift-build-dev <</font><a href="mailto:swift-build-dev@swift.org"><u><font size="7" color="#0000FF">swift-build-dev@swift.org</font></u></a><font size="7">> wrote:</font><p><font size="7">Thanks Daniel. I've created </font><a href="https://github.com/apple/swift-package-manager/pull/608"><u><font size="7" color="#0000FF">https://github.com/apple/swift-package-manager/pull/608</font></u></a><font size="7"> to disable the tests on non-macOS platforms.<br><br>Pull request #608 is for the swift-3.0-branch. Would I need to create another pull request for master? Wanted to see if the process is similar to </font><a href="https://github.com/apple/swift"><u><font size="7" color="#0000FF">https://github.com/apple/swift</font></u></a><font size="7">.<br><br>Thanks!<br><br>Regards,<br><br>Vivian Kong<br>Software Developer<br>IBM Canada Toronto Lab<br><br><graycol.gif></font><font size="7" color="#424282">Daniel Dunbar ---2016/08/16 11:11:16 AM---Those tests don't work on non-macOS yet. I suspect the problem is simply that they are conditionaliz</font><font size="6" color="#5F5F5F"><br><br>From: </font><font size="6">Daniel Dunbar <</font><a href="mailto:daniel@zuster.org"><u><font size="6" color="#0000FF">daniel@zuster.org</font></u></a><font size="6">></font><font size="6" color="#5F5F5F"><br>To: </font><font size="6">Vivian Kong/Toronto/IBM@IBMCA</font><font size="6" color="#5F5F5F"><br>Cc: </font><font size="6">"</font><a href="mailto:swift-build-dev@swift.org"><u><font size="6" color="#0000FF">swift-build-dev@swift.org</font></u></a><font size="6">" <</font><a href="mailto:swift-build-dev@swift.org"><u><font size="6" color="#0000FF">swift-build-dev@swift.org</font></u></a><font size="6">></font><font size="6" color="#5F5F5F"><br>Date: </font><font size="6">2016/08/16 11:11 AM</font><font size="6" color="#5F5F5F"><br>Subject: </font><font size="6">Re: [swift-build-dev] Test failures on s390x</font><font size="6" color="#5F5F5F"><br>Sent by: </font><a href="mailto:daniel.dunbar@gmail.com"><u><font size="6" color="#0000FF">daniel.dunbar@gmail.com</font></u></a><p><br><br><hr width="100%" size="2" align="left" noshade><font size="7"><br><br><br>Those tests don't work on non-macOS yet. I suspect the problem is simply that they are conditionalized on not-Linux vs only-macOS, but they probably shouldn't be running. <br><br>- Daniel<br><br>On Tuesday, August 16, 2016, Vivian Kong via swift-build-dev <</font><a href="mailto:swift-build-dev@swift.org"><u><font size="7" color="#0000FF">swift-build-dev@swift.org</font></u></a><font size="7">> wrote:</font><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><ul><font size="7">I ran into these 2 failing test cases in TestToolTests when I ran the SwiftPM tests on s390x. I'm looking for hints on how to fix this as I'm not sure why the Foundation and XCTest module can't be found.<br><br>Thanks and I appreciate the help!<br><br>Test Case 'TestToolTests.testVersion' started at 18:01:42.018<br>**** FAILURE EXECUTING SUBPROCESS ****<br>command: /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swift-test --version<br>SWIFT_EXEC: nil<br>output: Compile Swift Module 'Basic' (20 sources)<br>Compile Swift Module 'POSIXTests' (2 sources)<br>Compile Swift Module 'PackageDescriptionTests' (3 sources)<br>/localbox/vivkong/swift3/swiftpm/Tests/POSIXTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'<br>import XCTest<br>^<br>/localbox/vivkong/swift3/swiftpm/Tests/POSIXTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'<br>import XCTest<br>^<br>/localbox/vivkong/swift3/swiftpm/Tests/PackageDescriptionTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'<br>import XCTest<br>^<br>/localbox/vivkong/swift3/swiftpm/Tests/PackageDescriptionTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'<br>import XCTest<br>^<br>/localbox/vivkong/swift3/swiftpm/Tests/PackageDescriptionTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'<br>import XCTest<br>^<br>/localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'<br>import class Foundation.FileHandle<br>^<br>/localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'<br>import class Foundation.FileHandle<br>^<br>/localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'<br>import class Foundation.FileHandle<br>^<br>/localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'<br>import class Foundation.FileHandle<br>^<br>/localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'<br>import class Foundation.FileHandle<br>^<br>/localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'<br>import class Foundation.FileHandle<br>^<br>/localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'<br>import class Foundation.FileHandle<br>^<br>/localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'<br>import class Foundation.FileHandle<br>^<br><unknown>:0: error: build had 3 command failures<br>swift-test: error: exit(-1263376016): /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swift-build-tool -f /localbox/vivkong/swift3/swiftpm/.build/debug.yaml test<br><br>/localbox/vivkong/swift3/swiftpm/Tests/CommandsTests/TestToolTests.swift:26: error: TestToolTests.testVersion : XCTAssertTrue threw error "exit(152): /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swift-test --version" - <br>Test Case 'TestToolTests.testVersion' failed (1.2 seconds).<br>Test Suite 'TestToolTests' failed at 18:01:43.218<br>Executed 2 tests, with 2 failures (2 unexpected) in 2.248 (2.248) seconds<br><br>Regards,<br><br>Vivian Kong<br>Software Developer<br>IBM Canada Toronto Lab</font></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul><font size="7"><br>_______________________________________________<br>swift-build-dev mailing list</font><u><font size="4" color="#0000FF"><br></font></u><a href="mailto:swift-build-dev@swift.org"><u><font size="7" color="#0000FF">swift-build-dev@swift.org</font></u></a><u><font size="4" color="#0000FF"><br></font></u><a href="https://lists.swift.org/mailman/listinfo/swift-build-dev"><u><font size="7" color="#0000FF">https://lists.swift.org/mailman/listinfo/swift-build-dev</font></u></a></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul></ul><font size="5"><br></font></ul></ul></ul></ul><font size="4"><br><br></font></ul></ul><br><br><BR>
</body></html>