[swift-build-dev] [swift-evolution] [Review] SE-0179: Swift `run` Command

Richard Wei rxrwei at gmail.com
Wed May 17 05:32:31 CDT 2017


> What is your evaluation of the proposal?
Excellent, except that `--chdir` and `--in-dir` are confusing. Why not use a long, clear name, just like `—enable-prefetching`? Consider `—working-dir` & `—preexec-working-dir`.
> Is the problem being addressed significant enough to warrant a change to Swift?
Yes, esp when executables go into platform subfolders in Swift 4.
> Does this proposal fit well with the feel and direction of Swift?
Yes.
> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
Compares well. It’s very easy to use.
> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
A reasonably thorough read.

-Richard

> On May 16, 2017, at 08:09, Daniel Dunbar via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of SE-0179: Swift `run` Command begins now and runs through May 25th, 2017.
> 
> The proposal is available here:
> 
>   https://github.com/apple/swift-evolution/blob/master/proposals/0179-swift-run-command.md <https://github.com/apple/swift-evolution/blob/master/proposals/0179-swift-run-command.md>
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at
> 
>   https://lists.swift.org/mailman/listinfo/swift-build-dev <https://lists.swift.org/mailman/listinfo/swift-build-dev>
>   https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>
> 
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> Proposal link:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0179-swift-run-command.md <https://github.com/apple/swift-evolution/blob/master/proposals/0179-swift-run-command.md>
> Reply text
> 
> Other replies
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> What is your evaluation of the proposal?
> Is the problem being addressed significant enough to warrant a change to Swift?
> Does this proposal fit well with the feel and direction of Swift?
> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> More information about the Swift evolution process is available at:
> 
> https://github.com/apple/swift-evolution/blob/master/process.md <https://github.com/apple/swift-evolution/blob/master/process.md>
> Thank you,
> Daniel Dunbar (Review Manager)
> 
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-build-dev/attachments/20170517/e220736f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: Message signed with OpenPGP
URL: <https://lists.swift.org/pipermail/swift-build-dev/attachments/20170517/e220736f/attachment.sig>


More information about the swift-build-dev mailing list