[swift-build-dev] [swift-evolution] [Review] SE-0179: Swift `run` Command

[Xiaodi Wu]

On Mon, May 15, 2017 at 7:09 PM, Daniel Dunbar via swift-evolution <
swift-evolution at swift.org> wrote:

> Hello Swift community,
>
> The review of *SE-0179: Swift `run` Command* begins now and runs through *May
> 25th, 2017*.
>
> The proposal is available here:
>
>   https://github.com/apple/swift-evolution/blob/master/
> proposals/0179-swift-run-command.md
>
> Reviews are an important part of the Swift evolution process. All reviews
> should be sent to the swift-build-dev and swift-evolution mailing lists at
>
>   https://lists.swift.org/mailman/listinfo/swift-build-dev
>   https://lists.swift.org/mailman/listinfo/swift-evolution
>
> or, if you would like to keep your feedback private, directly to the
> review manager. When replying, please try to keep the proposal link at the
> top of the message:
>
> Proposal link:
>
> https://github.com/apple/swift-evolution/blob/master/
> proposals/0179-swift-run-command.md
> Reply text
>
> Other replies
>
> What goes into a review?
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Swift. When writing your review, here are some questions you might want to
> answer in your review:
>
>    - What is your evaluation of the proposal?
>
>
Excellent proposal overall. One particular point:

The name `--in-dir` doesn't mean anything to me. I foresee no way of
remembering which is `--chdir` and which is `--in-dir` other than
memorizing or looking it up. Intuitively, `--chdir` should mean the same
thing for each command (i.e. it should run before any other operation), so
I agree with the currently proposed design in that respect. The other
option could use a clearer name such as `--chdir-before-run`.


>    - Is the problem being addressed significant enough to warrant a
>    change to Swift?
>
>
An additive change, good net benefit.


>
>    - Does this proposal fit well with the feel and direction of Swift?
>
>
Yes.


>
>    - If you have used other languages or libraries with a similar
>    feature, how do you feel that this proposal compares to those?
>
>
Yes, it compares well.


>
>    - How much effort did you put into your review? A glance, a quick
>    reading, or an in-depth study?
>
>
A reasonably thorough reflection on the proposal.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-build-dev/attachments/20170516/013f3f81/attachment.html>