[swift-build-dev] [swift-evolution] [Review] SE-0158 Package Manager Manifest API Redesign

[David Hart]

> On 7 Mar 2017, at 21:53, Rick Ballard via swift-evolution <swift-evolution at swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of "SE-0158 Package Manager Manifest API Redesign" begins now and runs through March 13, 2017. The proposal is available here:
> 
> 	https://github.com/apple/swift-evolution/blob/master/proposals/0158-package-manager-manifest-api-redesign.md <https://github.com/apple/swift-evolution/blob/master/proposals/0158-package-manager-manifest-api-redesign.md>
> 
> Reviews are an important part of the Swift evolution process. All Swift Package Manager reviews should be sent to the swift-evolution and swift-build-dev mailing lists at
> 
> 	https://lists.swift.org/mailman/listinfo/swift-evolution
> 	https://lists.swift.org/mailman/listinfo/swift-build-dev
> 
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
> 
> > Proposal link:
> >>  https://github.com/apple/swift-evolution/blob/master/proposals/0158-package-manager-manifest-api-redesign.md
> 
> >  Reply text
> 
> >>  Other replies
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> * What is your evaluation of the proposal?

I’m strongly in favour of the modifications in this proposal. The small API modifications add more consistency and the new version definition APIs are well thought out and approchable for newcomers (compared to cryptic operators).

> * Is the problem being addressed significant enough to warrant a change to the Swift Package Manager?

Yes.

> * Does this proposal fit well with the feel and direction of Swift?

It would feel even better if Swift provided more customisation of enum cases and we could do away with the factory methods!

> * If you have used other languages, libraries, or package managers with a similar feature, how do you feel that this proposal compares to those?

I initially wanted a version definition syntax closer to what I’m used in Bundler, Cocoapods, Carthage, but I ended up liking the more wordy choice that was made in this proposal.

> * How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Read and gave feedback during the discussion period and quick read of the final proposal.

> More information about the Swift evolution process is available at
> 
> 	https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> 
> - Rick Ballard
> 
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-build-dev/attachments/20170307/6f07e037/attachment.html>