[swift-build-dev] [swift-evolution] [Review] SE-0149 Package Manager Support for Top of Tree development

[Boris Buegling]

Hi Derrick,

I think you meant to send this as a reply to SE-0149 Package Manager Support for branches, correct?

I’m not quite sure about the use case for your described behaviour, can you elaborate a bit more why you would want to override a dependency of A from the manifest of P? 

If the goal is a temporary override, the proposal already allows that by utilising `pin --branch`.

Cheers,
Boris

> On 25 Jan 2017, at 01:50, Derrick Ho via swift-evolution <swift-evolution at swift.org> wrote:
> 
> It probably is a good idea.
> 
> Perhaps the changes can be done in the Package.swift file but allow nesting of dependencies.
> 
> Suppose your dependency is like this where P is your current project
> 
> P --> A --> B
> 
> Normally P we would describe its dependency on A while B would be abstracted away. In A, there would be another Package.swift file describing its dependency on B.
> 
> However if we add the ability to NEST the dependency graph in P's Package.swift it could serve as an override to the default behavior.
> 
> import PackageDescription
> 
> let package = Package(
> name: "P",
> targets: [],
> dependencies: [
> .Package(url: "https://blah.com/A.git",
> majorVersion: 1, depdencies: [
> .Package(url: "https://blahblah.com/B.git, branch: "test")
> ]),
> 
> ]
> )
> 
> 
> On Tue, Jan 24, 2017 at 3:28 PM Daniel Dunbar via swift-evolution <swift-evolution at swift.org> wrote:
> I am reposting this since the URLs were mangled in the original email.
> 
> Hello Swift community,
> 
> The review of SE-0149 “ Package Manager Support for Top of Tree development" begins now and runs through January 31, 2017. The proposal is available here:
>   https://github.com/apple/swift-evolution/blob/master/proposals/0149-package-manager-top-of-tree.md
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at
>   https://lists.swift.org/mailman/listinfo/swift-build-dev
>   https://lists.swift.org/mailman/listinfo/swift-evolution
> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
>   https://github.com/apple/swift-evolution/blob/master/proposals/0149-package-manager-top-of-tree.md
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> 	• What is your evaluation of the proposal?
> 	• Is the problem being addressed significant enough to warrant a change to Swift?
> 	• Does this proposal fit well with the feel and direction of Swift?
> 	• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> 	• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> More information about the Swift evolution process is available at
>   https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> - Daniel
> 
> Review Manager
> 
>> On Jan 24, 2017, at 8:56 AM, Daniel Dunbar via swift-build-dev <swift-build-dev at swift.org> wrote:
>> 
>> Hello Swift community,
>> 
>> The review of SE-0149 “ Package Manager Support for Top of Tree development" begins now and runs through January 31, 2017. The proposal is available here:
>> 
>> https://github.com/apple/swift-evolution/blob/master/proposals/0149-package-manager-top-of-tree.md
>> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at
>> 
>> https://lists.swift.org/mailman/listinfo/swift-build-dev
>> https://lists.swift.org/mailman/listinfo/swift-evolution
>> or, if you would like to keep your feedback private, directly to the review manager. When replying, please try to keep the proposal link at the top of the message:
>> 
>> Proposal link:
>> 
>> https://github.com/apple/swift-evolution/blob/master/proposals/0149-package-manager-top-of-tree.md
>> Reply text
>> 
>> Other replies
>> What goes into a review?
>> 
>> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
>> 
>> 	• What is your evaluation of the proposal?
>> 	• Is the problem being addressed significant enough to warrant a change to Swift?
>> 	• Does this proposal fit well with the feel and direction of Swift?
>> 	• If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
>> 	• How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
>> More information about the Swift evolution process is available at
>> 
>> https://github.com/apple/swift-evolution/blob/master/process.md
>> Thank you,
>> 
>> - Daniel
>> 
>> Review Manager
>> 
>> _______________________________________________
>> swift-build-dev mailing list
>> swift-build-dev at swift.org
>> https://lists.swift.org/mailman/listinfo/swift-build-dev
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution