[swift-build-dev] [swift-evolution] [Review] SE-0150 Package Manager Support for branches

[Martin Waitz]

Hello,

Am 2017-01-24 19:18, schrieb Daniel Dunbar via swift-evolution:
> The review of SE-0150 “ Package Manager Support for branches" begins
> now and runs through January 31, 2017. The proposal is available here:
> 
> https://github.com/apple/swift-evolution/blob/master/proposals/0150-package-manager-branch-support.md

> What is your evaluation of the proposal?

-1
I think we should more clearly separate the contents of the manifest and 
the version pins file.
I don't like to have two competing ways to do the same thing.

The manifest file (`Packages.swift`) should contain all required 
dependencies while the pins file should contain specific versions.

If there the dependency has no released version yet that is fine!
But instead of hard-coding some version into the manifest, we should 
allow to specify dependencies without any version requirement.
The concrete branch/version specification should always be stored in the 
`Package.pins` file.
This way, we also don't have any problem with conflicting branch 
specifications.


> Is the problem being addressed significant enough to warrant a change 
> to Swift?

yes.
Bootstrapping and the ability to work with unreleased dependencies are 
important.


> Does this proposal fit well with the feel and direction of Swift?

no.
I'd like to keep the clear separation between `Package.swift` and 
`Package.pins`.


> If you have used other languages or libraries with a similar feature, 
> how do you feel that this proposal compares to those?

-

> How much effort did you put into your review? A glance, a quick 
> reading, or an in-depth study?

Quick Reading.


-- 
Martin