[swift-build-dev] [swift-evolution] [Review] SE-0145: Package Manager Version Pinning (Revised)

[Adrian Kashivskyy]

> What is your evaluation of the proposal?

+1. I think

> Is the problem being addressed significant enough to warrant a change to Swift?

Yes, version pinning is a must-have feature for collaboration in larger scale.

> Does this proposal fit well with the feel and direction of Swift?

Yes, and I admit I like `pinning` (as opposed to `locking` terminology.

> If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?

Yes - Bundler, Carthage, CocoaPods, Composer. This proposal is very similar to all of above.

> How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

Read the proposal and been following the discussions.

–––

I have a little feedback, though:

>> The exact file format is unspecified/implementation defined, however, in practice it will be a JSON data file.
> 
> Please make it VCS friendly format. If JSON, pretty-print please.

I agree that pins file should be VCS friendly so that diffs are immediately visible during code review and blame.

– Adrian

> Wiadomość napisana przez Anders Bertelrud via swift-evolution <swift-evolution at swift.org> w dniu 20.11.2016, o godz. 06:48:
> 
> Hello Swift community,
> 
> The review of "SE-0145: Package Manager Version Pinning" begins again after revisions, starting now and running through November 28th. The proposal is available here:
> 
> 	https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md <https://github.com/apple/swift-evolution/blob/master/proposals/0145-package-manager-version-pinning.md>
> 
> Reviews are an important part of the Swift evolution process. All reviews should be sent to the swift-build-dev and swift-evolution mailing lists at
> 
> 	https://lists.swift.org/mailman/listinfo/swift-build-dev <https://lists.swift.org/mailman/listinfo/swift-build-dev>
> 	https://lists.swift.org/mailman/listinfo/swift-evolution <https://lists.swift.org/mailman/listinfo/swift-evolution>
> 
> or, if you would like to keep your feedback private, directly to the review manager.
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and contribute to the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> 	* What is your evaluation of the proposal?
> 	* Is the problem being addressed significant enough to warrant a change to Swift?
> 	* Does this proposal fit well with the feel and direction of Swift?
> 	* If you have used other languages or libraries with a similar feature, how do you feel that this proposal compares to those?
> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
> 
> More information about the Swift evolution process is available at
> 
> 	https://github.com/apple/swift-evolution/blob/master/process.md <https://github.com/apple/swift-evolution/blob/master/process.md>
> 
> Thank you,
> 
> Anders Bertelrud
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-build-dev/attachments/20161128/23694bb9/attachment.html>