[swift-build-dev] Test failures on s390x

Tue Aug 16 12:58:19 CDT 2016

> On Aug 16, 2016, at 10:54 AM, Vivian Kong <vivkong at ca.ibm.com> wrote:
> 
> Sorry just want to be clear, can you elaborate what swift-test should be doing? It's trying to build with this command?
> 
The *test* in question is trying to run `swift-test --version`, which should do nothing other than print its own version number.
> /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swift-build-tool -f /localbox/vivkong/swift3/swiftpm/.build/debug.yaml test
> 
> Does that do that every time swift-test is being executed?
> 
Yes, during normal operation (when using the tool to actually run tests, it always builds them first).

 - Daniel
> 
> Regards,
> 
> Vivian Kong
> Software Developer
> IBM Canada Toronto Lab
> 
> <graycol.gif>Daniel Dunbar ---2016/08/16 01:21:41 PM---> On Aug 16, 2016, at 10:19 AM, Vivian Kong <vivkong at ca.ibm.com> wrote: >
> 
> From: Daniel Dunbar <daniel_dunbar at apple.com>
> To: Vivian Kong/Toronto/IBM at IBMCA
> Cc: Daniel Dunbar <daniel at zuster.org>, "swift-build-dev at swift.org" <swift-build-dev at swift.org>
> Date: 2016/08/16 01:21 PM
> Subject: Re: [swift-build-dev] Test failures on s390x
> Sent by: daniel_dunbar at apple.com
> 
> 
> 
> 
> On Aug 16, 2016, at 10:19 AM, Vivian Kong <vivkong at ca.ibm.com <mailto:vivkong at ca.ibm.com>> wrote:
> Thanks for clarifying! I just checked and my swift-test executable seems to have the correct RPATH (Foundation and XCTest paths are there).
> 
> And yes I didn't understand why when I execute swift-test it is trying to compile. Let me do a clean SwiftPM build again and check the log.
> 
> 
> That is normal behavior for the `swift-test` tool. It is just not normal behavior when run with `--version`.
> 
> - Daniel
> 
> Regards,
> 
> Vivian Kong
> Software Developer
> IBM Canada Toronto Lab
> 
> <graycol.gif>Daniel Dunbar ---2016/08/16 01:10:41 PM---I wasn't precise enough, we actually use RUNPATH currently. Here is what I see for a local build on
> 
> From: Daniel Dunbar <daniel_dunbar at apple.com <mailto:daniel_dunbar at apple.com>>
> To: Vivian Kong/Toronto/IBM at IBMCA
> Cc: Daniel Dunbar <daniel at zuster.org <mailto:daniel at zuster.org>>, "swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>" <swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>>
> Date: 2016/08/16 01:10 PM
> Subject: Re: [swift-build-dev] Test failures on s390x
> Sent by: daniel_dunbar at apple.com <mailto:daniel_dunbar at apple.com>
> 
> 
> 
> 
> I wasn't precise enough, we actually use RUNPATH currently. Here is what I see for a local build on Ubuntu 15.10:
> 
> ~/public/swift-project/swiftpm$ objdump -x ../build/Ninja-ReleaseAssert/swiftpm-linux-x86_64/debug/swift-test | grep RUNPATH 
> RUNPATH /home/ddunbar/public/swift-project/build/Ninja-ReleaseAssert/swift-linux-x86_64/lib/swift/linux:$ORIGIN/../lib/swift/linux:/home/ddunbar/public/swift-project/build/Ninja-ReleaseAssert/foundation-linux-x86_64/Foundation:/home/ddunbar/public/swift-project/build/Ninja-ReleaseAssert/xctest-linux-x86_64:$ORIGIN 
> 
> Note the Foundation and XCTest paths there.
> 
> Actually -- I just realized what is going on, it is something completely different.
> 
> Your `swift-test --version` command appears to be, for some reason or other, actually trying to execute the tests (instead of just printing the version). It shouldn't be doing that; is it possible there is a miscompile of swift-test here?
> 
> - Daniel
> On Aug 16, 2016, at 10:03 AM, Vivian Kong <vivkong at ca.ibm.com <mailto:vivkong at ca.ibm.com>> wrote:
> Sorry was having lunch =P
> 
> Makes sense! I tried doing 
> 
> objdump -x /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swiftc | grep RPATH
> 
> but it returns nothing.
> 
> I did the same thing on my build on x86_64 and got the same result. 
> 
> Regards,
> 
> Vivian Kong
> Software Developer
> IBM Canada Toronto Lab
> 
> <graycol.gif>Daniel Dunbar ---2016/08/16 12:43:38 PM---Hi Vivian, Did you see my follow up?
> 
> From: Daniel Dunbar <daniel_dunbar at apple.com <mailto:daniel_dunbar at apple.com>>
> To: Vivian Kong/Toronto/IBM at IBMCA
> Cc: Daniel Dunbar <daniel at zuster.org <mailto:daniel at zuster.org>>, "swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>" <swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>>
> Date: 2016/08/16 12:43 PM
> Subject: Re: [swift-build-dev] Test failures on s390x
> Sent by: daniel_dunbar at apple.com <mailto:daniel_dunbar at apple.com>
> 
> 
> 
> 
> Hi Vivian,
> 
> Did you see my follow up?
> 
> - Daniel
> On Aug 16, 2016, at 8:54 AM, Vivian Kong via swift-build-dev <swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>> wrote:
> Thanks Daniel. I've created https://github.com/apple/swift-package-manager/pull/608 <https://github.com/apple/swift-package-manager/pull/608> to disable the tests on non-macOS platforms.
> 
> Pull request #608 is for the swift-3.0-branch. Would I need to create another pull request for master? Wanted to see if the process is similar to https://github.com/apple/swift <https://github.com/apple/swift>.
> 
> Thanks!
> 
> Regards,
> 
> Vivian Kong
> Software Developer
> IBM Canada Toronto Lab
> 
> <graycol.gif>Daniel Dunbar ---2016/08/16 11:11:16 AM---Those tests don't work on non-macOS yet. I suspect the problem is simply that they are conditionaliz
> 
> From: Daniel Dunbar <daniel at zuster.org <mailto:daniel at zuster.org>>
> To: Vivian Kong/Toronto/IBM at IBMCA
> Cc: "swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>" <swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>>
> Date: 2016/08/16 11:11 AM
> Subject: Re: [swift-build-dev] Test failures on s390x
> Sent by: daniel.dunbar at gmail.com <mailto:daniel.dunbar at gmail.com>
> 
> 
> 
> 
> 
> Those tests don't work on non-macOS yet. I suspect the problem is simply that they are conditionalized on not-Linux vs only-macOS, but they probably shouldn't be running. 
> 
> - Daniel
> 
> On Tuesday, August 16, 2016, Vivian Kong via swift-build-dev <swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>> wrote:
> I ran into these 2 failing test cases in TestToolTests when I ran the SwiftPM tests on s390x. I'm looking for hints on how to fix this as I'm not sure why the Foundation and XCTest module can't be found.
> 
> Thanks and I appreciate the help!
> 
> Test Case 'TestToolTests.testVersion' started at 18:01:42.018
> **** FAILURE EXECUTING SUBPROCESS ****
> command: /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swift-test --version
> SWIFT_EXEC: nil
> output: Compile Swift Module 'Basic' (20 sources)
> Compile Swift Module 'POSIXTests' (2 sources)
> Compile Swift Module 'PackageDescriptionTests' (3 sources)
> /localbox/vivkong/swift3/swiftpm/Tests/POSIXTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'
> import XCTest
> ^
> /localbox/vivkong/swift3/swiftpm/Tests/POSIXTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'
> import XCTest
> ^
> /localbox/vivkong/swift3/swiftpm/Tests/PackageDescriptionTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'
> import XCTest
> ^
> /localbox/vivkong/swift3/swiftpm/Tests/PackageDescriptionTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'
> import XCTest
> ^
> /localbox/vivkong/swift3/swiftpm/Tests/PackageDescriptionTests/XCTestManifests.swift:11:8: error: no such module 'XCTest'
> import XCTest
> ^
> /localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'
> import class Foundation.FileHandle
> ^
> /localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'
> import class Foundation.FileHandle
> ^
> /localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'
> import class Foundation.FileHandle
> ^
> /localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'
> import class Foundation.FileHandle
> ^
> /localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'
> import class Foundation.FileHandle
> ^
> /localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'
> import class Foundation.FileHandle
> ^
> /localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'
> import class Foundation.FileHandle
> ^
> /localbox/vivkong/swift3/swiftpm/Sources/Basic/TemporaryFile.swift:13:14: error: no such module 'Foundation'
> import class Foundation.FileHandle
> ^
> <unknown>:0: error: build had 3 command failures
> swift-test: error: exit(-1263376016): /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swift-build-tool -f /localbox/vivkong/swift3/swiftpm/.build/debug.yaml test
> 
> /localbox/vivkong/swift3/swiftpm/Tests/CommandsTests/TestToolTests.swift:26: error: TestToolTests.testVersion : XCTAssertTrue threw error "exit(152): /localbox/vivkong/swift3/build/Ninja-RelWithDebInfoAssert/swiftpm-linux-s390x/debug/swift-test --version" - 
> Test Case 'TestToolTests.testVersion' failed (1.2 seconds).
> Test Suite 'TestToolTests' failed at 18:01:43.218
> Executed 2 tests, with 2 failures (2 unexpected) in 2.248 (2.248) seconds
> 
> Regards,
> 
> Vivian Kong
> Software Developer
> IBM Canada Toronto Lab
> 
> _______________________________________________
> swift-build-dev mailing list
> swift-build-dev at swift.org <mailto:swift-build-dev at swift.org>
> https://lists.swift.org/mailman/listinfo/swift-build-dev <https://lists.swift.org/mailman/listinfo/swift-build-dev>
> 
> 
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-build-dev/attachments/20160816/374dfdbb/attachment.html>