[swift-build-dev] [swift-evolution] [Review] SE-0063: SwiftPM System Module Search Paths

[Daniel Dunbar]

> On Apr 7, 2016, at 1:14 PM, Anders Bertelrud via swift-evolution <swift-evolution at swift.org> wrote:
> 
> The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of Swift. When writing your review, here are some questions you might want to answer in your review:
> 
> 	* What is your evaluation of the proposal?

I think it is a good direction.

I think we inevitably will need to interface more with system package managers in order to do a great job of being seamless and working out of the box, and while the addition of "providers" to the Package.swift is going to have a maintenance cost, it seems sensible to go ahead and start building out this support. This design also allows the community to effective contribute a lot of the information on the package name correspondence.

The one thing I feel the proposal lacks currently is how tag versioning information in the Swift package is going to correspond to the underlying system package. My expectation is that we probably want Swift system packages to try and adopt a versioning scheme which matches that of the underlying system package.

> 	* Is the problem being addressed significant enough to warrant a change to the Swift Package Manager?

Yes, this is a common initial pain point with using system modules, and will make it easier to understand the behavior in the context of other system package tools and standard project development environments (e.g., autoconf projects).

> 	* Does this proposal fit well with the feel and direction of the Swift Package Manager?

I think it fits well, the intention is to 

> 	* If you have you used other package managers with a similar feature, how do you feel that this proposal compares to those?

Not in this form.

> 	* How much effort did you put into your review? A glance, a quick reading, or an in-depth study?

In-depth study.

 - Daniel

> 
> More information about the Swift evolution process is available at
> 
> 	https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> 
> Anders
> Review Manager
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution