[swift-evolution] [SHORT Review] SE-0133: Rename `flatten()` to `joined()`

Jacob Bandes-Storch jtbandes at gmail.com
Mon Jul 25 03:17:40 CDT 2016


I wasn't explicit about that in the proposal, but I was intending that
these should be renamed too. There's a minor snag: JoinedSequence already
exists. I haven't taken a close look at both implementations yet, but it's
possible we could just combine them.

On Mon, Jul 25, 2016 at 12:46 AM, Charlie Monroe via swift-evolution <
swift-evolution at swift.org> wrote:

> Shouldn't the proposal also mention renaming FlattenCollection,
> FlattenBidirectionalCollection and FlattenSequence to
> Joined*(Collection|Sequence)? Or are these going to keep their name?
>
> > On Jul 25, 2016, at 8:10 AM, Chris Lattner via swift-evolution <
> swift-evolution at swift.org> wrote:
> >
> > Hello Swift community,
> >
> > The review of "SE-0133: Rename `flatten()` to `joined()`" begins now and
> runs through July 26.  Apologies for the short review cycle, but we’re
> right up against the end of source breaking changes for Swift 3.  The
> proposal is available here:
> >
> >
> https://github.com/apple/swift-evolution/blob/master/proposals/0133-rename-flatten-to-joined.md
> >
> > Reviews are an important part of the Swift evolution process. All
> reviews should be sent to the swift-evolution mailing list at
> >
> >       https://lists.swift.org/mailman/listinfo/swift-evolution
> >
> > or, if you would like to keep your feedback private, directly to the
> review manager.
> >
> > What goes into a review?
> >
> > The goal of the review process is to improve the proposal under review
> through constructive criticism and contribute to the direction of Swift.
> When writing your review, here are some questions you might want to answer
> in your review:
> >
> >       * What is your evaluation of the proposal?
> >       * Is the problem being addressed significant enough to warrant a
> change to Swift?
> >       * Does this proposal fit well with the feel and direction of Swift?
> >       * If you have used other languages or libraries with a similar
> feature, how do you feel that this proposal compares to those?
> >       * How much effort did you put into your review? A glance, a quick
> reading, or an in-depth study?
> >
> > More information about the Swift evolution process is available at
> >
> >       https://github.com/apple/swift-evolution/blob/master/process.md
> >
> > Thank you,
> >
> > -Chris Lattner
> > Review Manager
> > _______________________________________________
> > swift-evolution mailing list
> > swift-evolution at swift.org
> > https://lists.swift.org/mailman/listinfo/swift-evolution
>
> _______________________________________________
> swift-evolution mailing list
> swift-evolution at swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.swift.org/pipermail/swift-evolution/attachments/20160725/0b38a99b/attachment.html>


More information about the swift-evolution mailing list